Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Filterx func str performance improvements #472

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

bazsi
Copy link
Member

@bazsi bazsi commented Jan 24, 2025

This improves test coverage for startswith/endswith/includes as well as includes their performance by:

  • not using dynamically allocated GString and GPtrArray instances
  • using the glibc provided strstr() call instead of the one in glib

It uses a better algorithm (both glibc and musl).

Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
@bazsi bazsi force-pushed the filterx-func-str-performance-improvements branch from 31c4be9 to f776307 Compare January 24, 2025 20:43
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
@bazsi bazsi force-pushed the filterx-func-str-performance-improvements branch from f776307 to d8c0bbd Compare January 24, 2025 21:17
@MrAnno MrAnno merged commit 336e6f3 into axoflow:main Jan 27, 2025
22 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants