Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix/replace okp4 by axone #649

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Fix/replace okp4 by axone #649

merged 5 commits into from
Jan 27, 2025

Conversation

ccamel
Copy link
Member

@ccamel ccamel commented Jan 26, 2025

Updates the CLI installation guide to replace references to OKP4 with Axone.

+ cosmetic

Note: the tutorial is now quite outdated, and some of the described commands likely no longer work. We’ll need to review the content to ensure everything is up to date.

Summary by CodeRabbit

  • Documentation

    • Updated installation documentation with improved code snippet formatting.
    • Renamed CLI references from okp4d to axoned.
    • Updated wallet addresses from okp4 prefix to axone prefix.
    • Clarified CLI version compatibility and installation procedures.
  • Chores

    • Aligned documentation with new CLI branding and naming conventions.

Copy link

vercel bot commented Jan 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2025 6:51pm

Copy link
Contributor

coderabbitai bot commented Jan 26, 2025

Note

Reviews paused

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Walkthrough

The pull request introduces documentation updates for the Okp4/Axone blockchain project. The changes primarily focus on renaming the Command Line Interface (CLI) from okp4d to axoned, updating wallet addresses, and modifying code snippets. These modifications align the documentation with the new branding and ensure consistency across installation and tutorial instructions.

Changes

File Change Summary
docs/nodes/installation.mdx Updated code snippet formatting with curly braces for curl and docker commands.
docs/tutorials/cli-1.mdx Comprehensive rename from okp4d to axoned, including:
- CLI command updates
- Wallet address prefix changes from okp4 to axone
- URL and documentation references updated

Possibly related PRs

  • Fix/axone brand #592: The changes in this PR involve rebranding from "OKP4" to "Axone," which is relevant as the main PR also pertains to the documentation for the okp4d installation process, indicating a connection in the context of branding and documentation updates.

Suggested reviewers

  • amimart
  • AnjaMis

Poem

🐰 A Rabbit's Ode to Rebranding 🚀
From okp4d to axoned we leap,
Commands renamed, our changes deep
Wallet addresses shine anew
With axone prefix breaking through
Documentation dancing bright! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ccamel ccamel self-assigned this Jan 26, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (2)
docs/tutorials/cli-1.mdx (2)

27-31: Consider enhancing the version compatibility warning.

The caution note about version compatibility is crucial for preventing runtime issues. Consider:

  1. Making it more prominent by moving it before the installation steps
  2. Adding a command to check the network's version before installation
+### Check network version first
+
+Before installation, verify the network version:
+
+```bash
+curl -s https://explore.axone.xyz/api/v1/axone%20testnet/params | jq '.params[] | select(.param == "version")'
+```
+
 ### `axoned` one-liner installer script

 :::caution  
 The following installation procedure targets the latest released version of the axoned CLI, which may be ahead of the version currently supported by the targeted network.

 To ensure compatibility, make sure to install the version that matches the network's version. You can verify the correct version by checking the parameters of the network on the [Axone testnet explorer](https://explore.axone.xyz/Axone%20testnet/params).
 :::

413-419: Enhance documentation with cross-references.

The recap section could be more valuable by:

  1. Adding links to related documentation sections
  2. Including references to troubleshooting guides
 ## Recap'

 - The CLI allows you to communicate with the Axone blockchain
-  - To get started, you should install the `axoned` CLI and create (or import) a wallet
+  - To get started, you should [install the `axoned` CLI](#installing-the-axone-cli) and [create (or import) a wallet](#get-a-wallet-by-creating-a-new-key-pair)
 - Both native and smart contracts transactions are supported

 We've just scratched the surface of what's possible with the Axone CLI! For a more detailed look at available commands, please check our full documentation at [Axone Documentation](https://docs.axone.xyz/commands/axoned).
+
+For common issues and solutions, refer to our [Troubleshooting Guide](https://docs.axone.xyz/troubleshooting).

 Remember, the blockchain space moves quickly, and Axone is no exception. Stay in touch with our updates and feel free to join our active developer community. We're thrilled to have you on board!
🧰 Tools
🪛 LanguageTool

[style] ~419-~419: The phrase ‘feel free to’ is used quite frequently. Consider using a less frequent alternative to set your writing apart from others and make it sound more professional.
Context: ...ion. Stay in touch with our updates and feel free to join our active developer community. We...

(FEEL_FREE_TO_STYLE_ME)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 546e50b and 05e1fca.

📒 Files selected for processing (2)
  • docs/nodes/installation.mdx (2 hunks)
  • docs/tutorials/cli-1.mdx (15 hunks)
✅ Files skipped from review due to trivial changes (1)
  • docs/nodes/installation.mdx
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: lint-web
  • GitHub Check: lint-commits
  • GitHub Check: build-yarn

Copy link
Member

@bot-anik bot-anik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop http://localhost:3000/

Device URL
mobile http://localhost:3000/

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (2)
docs/tutorials/cli-1.mdx (2)

34-34: Add checksum verification step for binary downloads.

For security best practices, consider adding instructions to verify the downloaded binary's checksum.

+ # Verify the binary checksum
+ echo "<expected_checksum>  axoned" | sha256sum -c

127-128: Add denomination explanation for clarity.

Consider adding a note explaining the denomination conversion: 1 AXON = 1,000,000 uAXON (micro-AXON).

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 05e1fca and 36290b4.

📒 Files selected for processing (1)
  • docs/tutorials/cli-1.mdx (15 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/tutorials/cli-1.mdx

[uncategorized] ~117-~117: Possible missing comma found.
Context: ...vm8WkkoPLQR03JN"}' type: local ' ``` Here the terminal returns `axone1cu9wzlcyyxp...

(AI_HYDRA_LEO_MISSING_COMMA)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: lint-web
  • GitHub Check: build-yarn
  • GitHub Check: lint-commits
🔇 Additional comments (2)
docs/tutorials/cli-1.mdx (2)

174-175: Update example transaction hash.

The transaction hash 4DB4644E6146DE0E7239C5273F79C931193F542D62979ACB907C9368A315DCE1 is invalid on the Axone network. Please replace it with a valid transaction hash or add a note indicating it's a placeholder.

Also applies to: 196-197


Line range hint 1-417: Overall changes look good!

The rebranding from OKP4 to Axone has been implemented consistently throughout the documentation. The structure is clear, and examples are well-formatted.

@ccamel
Copy link
Member Author

ccamel commented Jan 26, 2025

@coderabbitai pause

Copy link
Contributor

coderabbitai bot commented Jan 26, 2025

✅ Actions performed

Reviews paused.

@ccamel ccamel force-pushed the fix/replace-okp4-by-axone branch from 36290b4 to 7f81921 Compare January 26, 2025 18:46
@ccamel
Copy link
Member Author

ccamel commented Jan 26, 2025

@coderabbitai resolve

Copy link
Contributor

coderabbitai bot commented Jan 26, 2025

✅ Actions performed

Comments resolved.

@ccamel ccamel merged commit c3d83fe into main Jan 27, 2025
15 checks passed
@ccamel ccamel deleted the fix/replace-okp4-by-axone branch January 27, 2025 09:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants