workaround(lsp-signature)!: fix input delay of nvim-cmp #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `on_attach` is deprecated; * Now lsp-signature won't adjust its position relative to the completion popup to avoid problematic functions (cmp.visible) being called.
ayamir
approved these changes
Jul 5, 2023
singlemancombat
pushed a commit
to singlemancombat/nvim-config
that referenced
this pull request
Jul 6, 2023
|
Does this fix work for you? Because I'm still experiencing input delay on my end. If I disable |
|
@YuCao16 This PR only reduces calls to diff --git a/lua/lsp_signature/helper.lua b/lua/lsp_signature/helper.lua
index 8d09a22..c3e32d6 100644
--- a/lua/lsp_signature/helper.lua
+++ b/lua/lsp_signature/helper.lua
@@ -697,7 +697,7 @@ end
helper.completion_visible = function()
local hascmp, cmp = pcall(require, 'cmp')
if hascmp then
- return cmp.visible()
+ return true
end
return fn.pumvisible() ~= 0The issue upstream is not every call to |
|
Will #890 fix that? |
Yes, it works, thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on_attachis deprecated;lsp_signaturewon't adjust its position relative to the completion popup to avoid problematic functions (cmp.visible) being called.