Bug fixes 3 #161
Merged
Bug fixes 3 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge upstream changes
Fix invalid handle value passed to CloseHandle, number of null pointer dereferences. Fix typo in main exec_check(&ProcessJob ...).
Fix snapshot handle never get closed after use.
The result of malloc call is not checked against failure.
The result of malloc call is not checked against failure.
The result of malloc call is not checked against failure.
Fix multiple bugs in VMDriverServices and actually make it work. However I don't know the purpose of checking these services because most of them are _host_ drivers and does not present in VM unless manually installed for some (none) reason. Fixed null pointer dereference in get_services - malloc result wasn't checked against failure.
The result of malloc call is not checked against failure.
Expression filter illegal constant. Probably copy-paste misprint. Result of CreateMutex is not checked.
Fixed CloseHandle call with invalid handle, token handle leak.
SetDebugPrivileges is not a flag, but a function. If it called once there is no point in calling it again.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove double call of SetDebugPrivileges in CreateRemoteThread_Injection
Fix multiple bugs in SetPrivilege routine
Fix unexpected behavior in SetHandleInformatiom_ProtectedHandle
Fix null pointer dereference in get_system_firmware routine
Fix multiple bugs in Services.cpp
Fix null pointer derefence in vmware_firmware_ACPI routine
Fix null pointer dereference in vbox_firmware_ACPI routine
Fix null pointer dereference in qemu_firmware_ACPI routine
Fix resource leak in ScanForModules_ToolHelp32 routine
Fix multiple bugs in ProcessJob routine