Add ASSIGN_PUBLIC_IP configuration option #28
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a configuration option for
assignPublicIp
in theawsvpcConfiguration
block. Setting theASSIGN_PUBLIC_IP
config option toENABLED
will result in a public IP address automatically being assigned to the new task. This new setting defaults toDISABLED
, which matches current behavior.Closes #23
Notes
This should result in a minor version bump to the next release.
Testing Instructions
vagrant ssh
./scripts/update
./scripts/manage ecsmanage migrate help
git checkout HEAD -- ./src/django/oar/settings.py
to revert the changes to that file and remove theASSIGN_PUBLIC_IP
setting../scripts/update
./scripts/manage ecsmanage migrate help