Fix ref to taskDefinition in describe_task_definition response #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The response for `describe_task_definition` contains several top-level keys, one of which is `taskDefinition`. In order to get task definition specific attributes (e.g., `networkMode`), the top-level `taskDefinition` key needs to be retrieved and assigned to `task_def`.
Merged
kellyi
approved these changes
Apr 29, 2019
There was a problem hiding this comment.
Tested this with https://github.com/azavea/pwd-garp/pull/835 and it worked! 👍
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The response for
describe_task_definitioncontains several top-level keys, one of which istaskDefinition. In order to get task definition specific attributes (e.g.,networkMode), the top-leveltaskDefinitionkey needs to be retrieved and assigned totask_def.Testing Instructions
Please use https://github.com/azavea/pwd-garp/pull/835 to test this PR.