-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Implement PSP34 standard #79
Conversation
I've added the support of Issues:
|
0fc7c39
to
0375a61
Compare
note: total_supply includes expired names as well unless cleared from state
The custom transfer function now expects bool params to retain previous state
0375a61
to
6825ba8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, most points I highlighted are naming/consistency-related.
When I run the tests locally I get the following warnings, you might want to fix this, too:
warning: unused variable: `operator`
--> azns_registry/lib.rs:1008:13
|
1008 | operator: &AccountId,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_operator`
|
= note: `#[warn(unused_variables)]` on by default
warning: unused variable: `from`
--> azns_registry/lib.rs:1009:13
|
1009 | from: &AccountId,
| ^^^^ help: if this is intentional, prefix it with an underscore: `_from`
warning: unused variable: `to`
--> azns_registry/lib.rs:1010:13
|
1010 | to: &AccountId,
| ^^ help: if this is intentional, prefix it with an underscore: `_to`
warning: unused variable: `id`
--> azns_registry/lib.rs:1011:13
|
1011 | id: &Id,
| ^^ help: if this is intentional, prefix it with an underscore: `_id`
warning: unused variable: `data`
--> azns_registry/lib.rs:1012:13
|
1012 | data: &Vec<u8>,
| ^^^^ help: if this is intentional, prefix it with an underscore: `_data`
Closes #6