refactor: replace recursion with dowhile

azerothcore · Feb 14, 2025 · 0df7105 · 0df7105
1 parent b70c09e
commit 0df7105
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/server/scripts/Outland/BlackTemple/boss_illidan.cpp b/src/server/scripts/Outland/BlackTemple/boss_illidan.cpp
@@ -696,11 +696,11 @@ struct boss_illidan_stormrage : public BossAI
 
     void CycleBeamPos(uint8 &beamPosId)
     {
-        uint8 _incumbentBeamPos = urand(0, MAX_EYE_BEAM_POS - 1);
-        if (_incumbentBeamPos == beamPosId)
-            CycleBeamPos(beamPosId);
-        else
-            beamPosId = _incumbentBeamPos;
+        uint8 newPos;
+        do {
+            newPos = urand(0, MAX_EYE_BEAM_POS - 1);
+        } while (newPos == beamPosId);
+        beamPosId = newPos;
     }
 };