Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(Core/DB) - Correct the max length of a username #21183

Merged

Conversation

TheSCREWEDSoftware
Copy link
Contributor

@TheSCREWEDSoftware TheSCREWEDSoftware commented Jan 15, 2025

Warning

If any existing username have more than 17 characters after this PR or testing I don't know how SQL database reacts to that (when i had it active and tried lowering it didnt allow me until i changed or removed the username with more than 17 characters.

Client limitation on creating username is of 17 characters. (AC has it set to 20).
Tested on 2 clean clients.
3.3.5 (12340) enGB
3.3.5 (12340) enUS

Updated acore_world.acore_string 55 and 1005 (LANG_PASSWORD_TOO_LONG and LANG_ACCOUNT_TOO_LONG)

  • Adds French and Russian Locale to 55.
  • Adds French, Spain Spanish, Mexican Spanish and Russian Locale to 1005
  • German grammer was corrected for 1005.
  • Corrected all previous 20 character max in 1005 to 17.

Updated the acore_auth.account username field from 32 to 17 chracters length.
Note: I do not know if this size does or not changes for non-latin characters like russian.

No changes to the password in core as it set correctly (max of 16 chracters).

Thanks @r-o-b-o-t-o for the french translation and @55Honey for the correction on the grammar.

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

  • Closes N/A

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found
  • Used the client

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.
  • .account create AccountWithEnough 123 // 17 chars
  • Join your client, no disconenct. (before and after pr)
  • .account create AccountWithEnoughs 123 // 18 chars
  • Join your client, disconnect (before pr), after PR you can't create an account with more than 17 chars.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

Tested on 2 clean clients.
3.3.5 (12340) enGB
3.3.5 (12340) enUS
Upon creating a user with higher than 17 It's an auto disconnect. Password is unchanged from TC or Mangos which is 16, higher does the same error.
LANG_PASSWORD_TOO_LONG` gets addition to French and Russian.

`LANG_ACCOUNT_TOO_LONG` gets addition to French, Spain Spanish, Mexican Spanish and Russian.

Corrected german grammer and all from 20 to 17 (characters max)
Changed the max of a username length to match the client limit.
@github-actions github-actions bot added DB related to the SQL database CORE Related to the core file-cpp Used to trigger the matrix build labels Jan 15, 2025
@@ -0,0 +1,3 @@
--
-- Changes the Length of `username` from 32 to 17 characters as it the client limit.
ALTER TABLE `account` CHANGE COLUMN `username` `username` VARCHAR(17) NOT NULL DEFAULT '' COLLATE 'utf8mb4_unicode_ci' AFTER `id`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving it varchar(32) could have some benefits and save us from headaches.

  1. Changing it would error for everyone who for some reason has a username > 17
  2. It doesn't really matter as
    • The client would crash
    • Creating a new account/changing username through the console it would send AOR_NAME_TOO_LONG anyways

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you and sud suggested, i've removed changes to the column

@sudlud sudlud merged commit eb37cd8 into azerothcore:master Jan 19, 2025
18 checks passed
skelUA pushed a commit to skelUA/wotlk that referenced this pull request Jan 26, 2025
nl-saw added a commit to nl-saw/azerothcore-wotlk that referenced this pull request Feb 16, 2025
* chore(DB): import pending files

Referenced commit(s): c1e7c2e

* fix(DB/Creature) Add Waypoint and Creature Formation for Medicine Man and Wind Walker (azerothcore#21108)

* chore(DB): import pending files

Referenced commit(s): aa0f3f4

* fix(Core/Misc): Correct some fmt logs (azerothcore#21106)

* fix(DB/Loot) Sealed Craftsman's Writ loot problem (azerothcore#20981)

* chore(DB): import pending files

Referenced commit(s): 7303805

* fix(DB/Conditions): remove conditions for Rune of Mazthoril (azerothcore#21053)

* chore(DB): import pending files

Referenced commit(s): 0c2d735

* fix(Scripts/Halion): Halion freeze against "Feign Death" hunters (azerothcore#21093)

* fix(Scripts/ZulAman): Scout's hut search should ignore the world trigger near Jan'alai (azerothcore#21113)

* fix(Scripts/ZulAman): Increase Jan'alai teleport exclusion zone (azerothcore#21115)

* fix(Core/Threading): Modernize/Improve thread safety, performance, and maintainability of the MapUpdater class (azerothcore#21081)

Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>

* fix(Scripts/SunwellPlateau): Muru - Changed the amount of Tick Negative Energy Periodic (azerothcore#21102)

* fix(DB/Creatures) Remove Tanzar from his cage and activate group loot for its chest. (azerothcore#21120)

* chore(DB): import pending files

Referenced commit(s): f7c9170

* fix(Scripts/Spells): Move Curse of Mending (7098 & 39647) to spell sc… (azerothcore#21117)

* chore(DB): import pending files

Referenced commit(s): fb37497

* fix(Core/World): edge case when last Char on realm was deleted (azerothcore#20864)

* fix(DB/Creature)Badlands Reagent Run II dragons don't aggro when sucking blood (azerothcore#21021)

* chore(DB): import pending files

Referenced commit(s): 70c34bd

* fix(Scripts/ShatteredHalls): Add scripts & spawn for quest "Imprisoned in the citadel" (azerothcore#21114)

* chore(DB): import pending files

Referenced commit(s): fcfa351

* fix(Scripts/ZulAman): Limit target search range for Cyclones (azerothcore#21131)

* fix(Scripts/ZulAman): Zul'jin Add Cooldown to EnergyStorm proc (azerothcore#21132)

* chore(DB): import pending files

Referenced commit(s): 564ccd9

* fix(Scripts/ZulAman): Fix Hexlord gate not opening after crashes (azerothcore#21133)

* fix(Player/SpellQueue): bandaid crashfix (azerothcore#21103)

* feat(Scripts/Commands): Update GetBossState to display all states (azerothcore#21134)

* chore(DB): import pending files

Referenced commit(s): 3e465dd

* feat(Scripts/Commands): Implement opendoor command (azerothcore#21136)

* chore(DB): import pending files

Referenced commit(s): 07937d3

* fix(DB/Creature): Akil'zon interrupt immunity (azerothcore#21130)

* chore(DB): import pending files

Referenced commit(s): ea28a9f

* fix(DB/SAI): Fix Marauding Bursters repositioning in combat (azerothcore#21135)

* chore(DB): import pending files

Referenced commit(s): fe30831

* feat(CMake/Eluna): Update CMakeLists for modules to allow Eluna to switch Lua version (azerothcore#21123)

* fix(DB/Creature) - Removes weapons from Rorgish Jowl (azerothcore#21142)

* chore(DB): import pending files

Referenced commit(s): 849e104

* fix(DB/Loot): Malacrass should drop 2 pieces of loot and sometimes Tiny Vodoo Mask (azerothcore#21139)

* chore(DB): import pending files

Referenced commit(s): e9dfbe0

* fix(Scripts/ZulAman): Use Zul'jins threatlist to search for cyclone t… (azerothcore#21138)

* fix(Core/Group): CF Faction Assign & Leader Instance Faction (azerothcore#21118)

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* fix(DB/Conditions): Havenshire horses spellclick should require Grand… (azerothcore#21154)

* chore(DB): import pending files

Referenced commit(s): 3d1efbd

* fix(Core/Map): Fix crash OnPlayerLeave() (azerothcore#21155)

* fix(DB/SAI): Sunfury Bloodwarder do not intercept anymore (azerothcore#21147)

* chore(DB): import pending files

Referenced commit(s): 10be6b0

* fix(DB/page_text) - Added Sniffed Texts to the plaques in Hall of Champions (Scarlet Monastery Armoury) (azerothcore#21157)

co-author @heyitsbench

* fix(Scripts/ZulAman): Store chest count in DB (azerothcore#21160)

* chore(DB): import pending files

Referenced commit(s): 29f9187

* fix(DB/Creature) Remove double Nerub'ar Victims and set a Crystalline Tender movement type to 0. (azerothcore#21153)

* chore(DB): import pending files

Referenced commit(s): b1d72f1

* fix(Scripts/ZulAman): Akilzon Gauntlet hyperspawn, handling Eagle Trash Triggers (azerothcore#21129)

* chore(DB): import pending files

Referenced commit(s): 995eed8

* fix(DB/Creature) Solve some npc problems along the road to Drakos. (azerothcore#21152)

* chore(DB): import pending files

Referenced commit(s): 6c4db8e

* fix(DB/SAI): Amani'shi Berserker SAI (azerothcore#21165)

* chore(DB): import pending files

Referenced commit(s): ea63eb6

* fix(Scripts/ZulAman): Zul'Jin reduce procs of Energy Storm Aura (azerothcore#21169)

* chore(DB): import pending files

Referenced commit(s): a1cf6a7

* fix(DB/Spell): fix item "Blessed Medallion of Karabor" (azerothcore#20948)

Co-authored-by: Grimdhex <176165533+Grimdhex@users.noreply.github.com>

* chore(DB): import pending files

Referenced commit(s): 1db36de

* fix(DB/Creature) Some Borean Tundra npcs now have a smartai.  (azerothcore#21171)

* chore(DB): import pending files

Referenced commit(s): d234af1

* fix(DB/Spell): Correct map ID for Medallion of Karabor. (azerothcore#21175)

* chore(DB): import pending files

Referenced commit(s): 3f1d54b

* fix(Scripts/ZulAman): prevent early engaging of door guardians to skip timed event (azerothcore#21177)

* chore(DB): import pending files

Referenced commit(s): aefd3a5

* fix(Scripts/Silverpine): Fix Fearleia not reseting and modernize Pyre… (azerothcore#21159)

* chore(DB): import pending files

Referenced commit(s): 14dda24

* fix(DB/SAI): Amani Lynx shouldn't use dash (azerothcore#21187)

* fix(DB/SAI): Tamed Amani Crocolisk abilities (azerothcore#21188)

* chore(DB): import pending files

Referenced commit(s): 4328567

* fix(DB/Spell): Add sniffed data for Medallion of Karabor. (azerothcore#21185)

* chore(DB): import pending files

Referenced commit(s): 8c9dd1a

* refactor(Core/SmartScripts): Clean up validation logic by replacing A… (azerothcore#21184)

* refactor(Github/Misc): Deprecate Suggestion label and use Github Type (azerothcore#21192)

* fix(DB/Creature) Bloodscalp Witch Doctor can now move during combat. (azerothcore#21189)

* chore(DB): import pending files

Referenced commit(s): de0b113

* fix(DB/Creature): Remove rooted inhabit type from Coilfang Beast Tamer (azerothcore#21196)

* chore(DB): import pending files

Referenced commit(s): 38548a9

* fix(Core/Misc): Resolve output formatting issues with fmt library (azerothcore#21191)

* fix(Script/WP): correct output of wp show command (azerothcore#21193)

* chore(DB): import pending files

Referenced commit(s): 12aa9dc

* refactor(Core/Instances): Implement GetTeamIdInInstance() for two-fac… (azerothcore#21168)

* fix(Core/Unit): Fix fast creatures chasing indefinitely (azerothcore#21200)

* fix(DB/Gameobject): pooling and sniffed Values for 19018 'Giant Clam' spawns (azerothcore#21197)

* chore(DB): import pending files

Referenced commit(s): 818c03c

* fix(DB/Creature) Kel'thuzad no longer attacks players. (azerothcore#21199)

* chore(DB): import pending files

Referenced commit(s): 01f34b2

* feat(Scripting/Spell): Add new hooks for Spell (OnSpellCast, OnSpellPrepare, OnSpellCancel) (azerothcore#21149)

* fix(DB/Gameobject): Pooling and sniffed Values for 2744 'Giant Clam' spawns (azerothcore#21203)

* chore(DB): import pending files

Referenced commit(s): d840e7e

* feat(Core) - Additional "ActionButton" log information. (azerothcore#21201)

* fix(Scripts/Naxxramas): fixed invalid horseman state on instance init (azerothcore#21167)

* fix(Core/DB) - Correct the max length of a username to 17 characters (azerothcore#21183)

* chore(DB): import pending files

Referenced commit(s): eb37cd8

* fix(Scripts/ScarletMonastery): improvement ScarletMonastery (azerothcore#17558)

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* chore(DB): import pending files

Referenced commit(s): 9db9c42

* chore(Docker): Update dev container to ubuntu24.04 (azerothcore#21044)

* fix(Core/ObjectMgr): Potential crash in GetModuleString() (azerothcore#21211)

* refactor(Scripts/BloodFurnace): Clean up instance script (azerothcore#21207)

* fix(Core/Gameobject): prevent getting empty fishing loot (azerothcore#21216)

* refactor(Core/Loot): Simplify GetFishLoot with for loop and merge Get… (azerothcore#21217)

* chore(Apps/Codestyle): add new checks for SQL files (azerothcore#21026)

* refactor(Core/Player): Improve Channel.RestrictedLfg handling (azerothcore#21145)

* fix(Core/Instances): Ensure team is acquired before spawning creatures (azerothcore#21221)

* fix(DB/Creature) Various Shoveltusk SmartAI added. (azerothcore#21234)

* fix(DB/Creature) Fel Crystals no longer follow players. (azerothcore#21227)

* chore(DB): import pending files

Referenced commit(s): 3870426

* fix(DB/Creature) Sunblade Sentinel "Fel Lighting" has different timers and comment updated. (azerothcore#21229)

* chore(DB): import pending files

Referenced commit(s): 4927d20

* fix(DB/SAI): Kael'Thas Phoenix now only use fireball during gravity Lapse. (azerothcore#21244)

* fix(Scripts/MagistersTerrace): Pheonix will now reset after death (azerothcore#21240)

* chore(DB): import pending files

Referenced commit(s): f0507fb

* fix(Scripts/MagistersTerrace) Add 5s Vexallus Pure Energy (azerothcore#21239)

Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com>

* fix(DB/Creature): Felblood Kael'thas should despawn on evade (azerothcore#21246)

* fix(Scripts/MagisterTerrace): Implement missing Kaelthas text line (azerothcore#21247)

* chore(DB): import pending files

Referenced commit(s): eee1a8b

* fix(DB/Creature): Correct Sunblade Sentinel fel lightning (azerothcore#21245)

* chore(DB): import pending files

Referenced commit(s): 2ca4551

* fix(Core/Threading): Refactored LockedQueue / MPSCQueue - Improve thread safety, performance, and memory management (azerothcore#21127)

* fix(DB/Creature): Fix Flamestrike inhabit types (azerothcore#21249)

* chore(DB): import pending files

Referenced commit(s): d99285e

* fix(Scripts/MagisterTerrace): Fix Phoenixes and eggs not despawning (azerothcore#21260)

* fix(DB/Loot) Clean up loot of bosses in MGT HC (azerothcore#21262)

* chore(DB): import pending files

Referenced commit(s): c54de87

* fix(DB/Gameobject): remove extra Sanctum Planetarium (azerothcore#21251)

* chore(DB): import pending files

Referenced commit(s): d3cdd2f

* fix(Apps/Codestyle): ignore comments for some checks (azerothcore#21268)

* fix(DB/SAI): Correct Phoenix/Egg rebirth and combat behaviour (azerothcore#21261)

* chore(DB): import pending files

Referenced commit(s): f420195

* fix(Core/Auction):  Fix  usable item search in auction (azerothcore#21267)

* fix(Scripts/BlackTemple): Fix Gurtogg will not use acidic wound in phase 2 (azerothcore#21253)

* SECURITY.md File Update  (azerothcore#20190)

* feat(Core/Autobroacast): Add autobroadcast locale (azerothcore#20946)

* chore(DB): import pending files

Referenced commit(s): a74e06c

* feat(Core/Creatures): implement a sparring system (azerothcore#19824)

* chore(DB): import pending files

Referenced commit(s): edf2959

* fix(DB/Creature) Several Dragonflayers now have a SmartAI. (azerothcore#21275)

* chore(DB): import pending files

Referenced commit(s): f824f15

* fix(DB/SAI) - Fixes quest Counterattack! sometimes not being completed and adds 1 ability to the creature. (azerothcore#21050)

* chore(DB): import pending files

Referenced commit(s): dc0f77e

* feat(Core/Unit): Implement SetEmoteState() and ClearEmoteState() helpers (azerothcore#21279)

* refactor(Core/Motd): improve and simplify (azerothcore#21252)

* chore(DB): import pending files

Referenced commit(s): 9b3d54d

* fix(Scripts/MagisterTerrace): Rescript Kael's intro (azerothcore#21278)

* chore(DB): import pending files

Referenced commit(s): ed99f05

* fix(DB/SAI) Fix Amani Trainer Abilities (azerothcore#21269)

* chore(DB): import pending files

Referenced commit(s): 33eedba

* fix(DB/Creature) Update Amani Trainer SmartAI comments. (azerothcore#21282)

* chore(DB): import pending files

Referenced commit(s): 1c036f6

* fix(Scripts/SunwellPlateau): Fix Madrigosa flight movement (azerothcore#21290)

* fix(Scripts/MagisterTerrace): Fix Kael's outro and close door during … (azerothcore#21289)

* fix(Scripts/SunwellPlateau): Fix Felmyst start fight (azerothcore#21291)

* feat(Core/WorldState): implement Battle for Sun's Reach Event (azerothcore#21219)

Co-authored-by: killerwife <killerwife@gmail.com>
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Co-authored-by: MantisLord <sabinprosper@gmail.com>

* chore(DB): import pending files

Referenced commit(s): 00b8a3f

* fix(Scripts/MagisterTerrace/DB) Vexallus Boss Complete Overhaul (azerothcore#21266)

* chore(DB): import pending files

Referenced commit(s): 9c214f0

* fix(DB/SAI): Fix Brightscale Wyrm Energy Infusion (azerothcore#21304)

* chore(DB): import pending files

Referenced commit(s): 22e028b

* refactor(Scripts/MagisterTerrace): Clean up Vexallus instance script … (azerothcore#21303)

* chore(DB): import pending files

Referenced commit(s): c94f41d

* fix(DB/Misc): Bad delete in update file (azerothcore#21307)

Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com>

* refactor(Core/ObjectMgr): Change GetAcoreString from char const* to s… (azerothcore#21213)

...ring

* chore(DB): import pending files

Referenced commit(s): 9e9a2fe

* refactor(Core/Disables): Convert from Namespace to Class Structure (azerothcore#21109)

* feat(Core/SAI): implement SMART_ACTION_DISABLE_REWARD (azerothcore#21105)

* fix(DB/Locale) Minor fix Russian locale of quests (azerothcore#21313)

* chore(DB): import pending files

Referenced commit(s): 990b9a5

* fix(Scripts/SunwellPlateau): Remove Sunwell Radiance from mobs (azerothcore#21312)

* chore(DB): import pending files

Referenced commit(s): cce6f75

* fix(Script/ZulAman): Don't start the timer before Harrison Johnes event (azerothcore#21311)

* fix(Scripts/Oculus): Prevent boss Urom teleportation to nowhere on fast kill (azerothcore#21305)

Co-authored-by: Hexadecimal <hd@hd.hd>

* Feat(Core/Scripting): Add new hook CanPlayerResurrect to simplify HardCore mod etc. (azerothcore#21272)

* fix(DB/updates): add missing backticks to 2025_02_03_00.sql (azerothcore#21320)

* feat(CI/Codestyle): backtick check for sql (azerothcore#21321)

* fix(CI/Windows): fix windows build (azerothcore#21322)

* feat(Core/Scripting): Add new hook OnUnitSetShapeshiftForm (azerothcore#21235)

* Feat(Core/Player): Add ExtraBonusTalentCount methods (azerothcore#21271)

* fix(DB/SAI): Escape from Jaedanar group completion (azerothcore#21286)

* chore(DB): import pending files

Referenced commit(s): 7e2d5c4

* fix(Scripts/Spells): Fix Isle of Queldanas Orb of Translocation (azerothcore#21325)

* chore(DB): import pending files

Referenced commit(s): be422f2

* fix(DB/world): delete base/db_world/player_classlevelstats.sql (azerothcore#21329)

* fix(CI/Codestyle): Backtick check SET, quote and REPLACE case (azerothcore#21333)

* fix(DB/Creature) Various Northrend NPCs have SmartAI now. (azerothcore#21330)

* chore(DB): import pending files

Referenced commit(s): 3de0b91

* fix(DB/Creature): Kalecgos should despawn on evade (azerothcore#21335)

* fix(Scripts/SunwellPlateau): Felmyst should be invincible while flying (azerothcore#21336)

* chore(DB): import pending files

Referenced commit(s): 811342c

* fix(DB/Text): Fix Brutallus text language (azerothcore#21338)

* chore(DB): import pending files

Referenced commit(s): 585b896

* fix(Core/Battlefield): Wintergrasp out of bounds error when setting neutral faction of stalker (azerothcore#21340)

* fix(Scripts/IcecrownCitadel): Sindragosa P3 Exploit (azerothcore#20938)

Co-authored-by: Jelle Meeus <sogladev@gmail.com>

* fix(Script/ICC): Make Sindragosa Tail Smash - ignore LOS(azerothcore#20935)

* fix(DB/SAI): Add target type correction for spell 43458 (Secrets of Wyrmskull) (azerothcore#20294)

Co-authored-by: cgrahamseven <chris.graham@protonmail.com>

* chore(DB): import pending files

Referenced commit(s): db877ab

* fix(DB/creature_template-skinning_loot_template): Removed some wrong skinloot template (azerothcore#18626)

* chore(DB): import pending files

Referenced commit(s): 1760072

* chore(Deps/Zlib): move to Cloudflare fork (azerothcore#21028)

Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com>

* fix(Scripts/Northrend): Exclude Dalaran Sewer Exit Pipe from GUARD teleport checks (azerothcore#21222)

* fix(DB/Creature): Fix gold drop rate for sunfury mobs in netherstorm (azerothcore#21250)

* chore(DB): import pending files

Referenced commit(s): ce3a25e

* fix(CI/Codestyle): Ignore comments for backtick check (azerothcore#21343)

* fix(CI/Codestyle): ignore lines starting with @ (azerothcore#21346)

* fix(DB/CreatureAddon): add hawkstriker mount to Sun's Reach patrol (azerothcore#21345)

* chore(DB): import pending files

Referenced commit(s): 2ec792c

* fix(CI): typo (azerothcore#21347)

* fix(DB/Creature) Enable mining for Iron Rune Sentinel (azerothcore#21348)

* fix(DB/Creature) Thornvine Creeper is skinnable with herbalism. (azerothcore#21350)

* chore(DB): import pending files

Referenced commit(s): edb49c8

* fix(DB/Creature) Theremis, Archmage and Yrma floating now. (azerothcore#21349)

* chore(Core/EventMgr): Align code to Code standard & improve LoadFromDB function (azerothcore#21151)

Co-authored-by: Jelle Meeus <sogladev@gmail.com>
Co-authored-by: Ludwig <sudlud@users.noreply.github.com>

* fix(DB/Creature): Remove aggro from Abandoned Fuel Tank (azerothcore#21352)

* chore(DB): import pending files

Referenced commit(s): 7916db5

* fix(Core): Fix After PR#21213 Crash (azerothcore#21327)

* fix(DB/Quest): Remove Failed Incursion requirement from Lost in Action (azerothcore#21353)

* chore(DB): import pending files

Referenced commit(s): 4fa8050

* fix(Core/Transport): Fix for passengers dropped in the middle of nowhere  (azerothcore#21296)

* fix(CI/Codestyle): Final fixes to backtick check (azerothcore#21361)

* feat(Core/Creature): Implement HasFlagsExtra() helper to creature (azerothcore#21362)

* Revert "chore(Deps/Zlib): move to Cloudflare fork (azerothcore#21028)" (azerothcore#21364)

* fix(DB/SAI) add Kaylaan smart ai (azerothcore#21293)

* chore(DB): import pending files

Referenced commit(s): 9eeaef5

* fix(DB/Conditions): Sunwell Gates progress gossip (azerothcore#21344)

Co-authored-by: sudlud <sudlud@users.noreply.github.com>
Co-authored-by: Rocco Silipo <108557877+Rorschach91@users.noreply.github.com>

* chore(DB): import pending files

Referenced commit(s): cf103be

* chore(DB): Add missing file extension for query. (azerothcore#21368)

* fix(DB/Creature): Correct run speed of Kael'thas's Arcane Spheres on heroic. (azerothcore#21367)

* chore(DB): import pending files

Referenced commit(s): fcf9725

* fix(Core/Worldstate): sunsreach print correct counter (azerothcore#21356)

* fix(Scripts/SunwellPleateau): Remove invincibility from human kalecgos (azerothcore#21369)

* fix(Scripts/SunwellPlateau): Correct Felmyst spawn event (azerothcore#21360)

* chore(DB): import pending files

Referenced commit(s): 3c8823a

* fix(Core/Creature): Allow temp summons to respawn when despawning on … (azerothcore#21363)

* fix(DB/SAI): Fix Doomfire Shard Avenging Wrath spell (azerothcore#21377)

* chore(DB): import pending files

Referenced commit(s): d041243

* fix(Scripts/SunwellPlateau): Prevent Sathrovarr summon event from dou… (azerothcore#21376)

* fix(Scripts/SunwellPlateau): Clear basic events on death (azerothcore#21374)

* fix(Core/PacketIO): Implemented CMSG_BUSY_TRADE and CMSG_IGNORE_TRADE. (azerothcore#21385)

* fix(CI/Codestyle): correct double semicolon check (azerothcore#21388)

* fix(DB/Creature) Dawnblade Hawkriders and Shattered Sun Marksmen behaviours. (azerothcore#21341)

* chore(DB): import pending files

Referenced commit(s): 489d668

* fix(Scripts/SunwellPlateau): Don't replay Felmyst intro after wipes (azerothcore#21398)

Felmyst into no longer relays after a wipe.

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rocco Silipo <108557877+Rorschach91@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Exitare <Exitare@users.noreply.github.com>
Co-authored-by: Jelle Meeus <sogladev@gmail.com>
Co-authored-by: EricksOliveira <ericksoliveira258@gmail.com>
Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com>
Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>
Co-authored-by: Yunfan Li <lyf_liyunfan@sina.com>
Co-authored-by: Tralenor <76077537+Tralenor@users.noreply.github.com>
Co-authored-by: iThorgrim <125808072+iThorgrim@users.noreply.github.com>
Co-authored-by: FlyingArowana <AugustoMendes4426@gmail.com>
Co-authored-by: Tereneckla <Tereneckla@pm.me>
Co-authored-by: manstfu <33990720+manstfu@users.noreply.github.com>
Co-authored-by: Grimdhex <176165533+Grimdhex@users.noreply.github.com>
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Co-authored-by: sudlud <sudlud@users.noreply.github.com>
Co-authored-by: Razor2142 <Razor2142@graveyardgames.net>
Co-authored-by: daobashun <49193927+fangshun2004@users.noreply.github.com>
Co-authored-by: blinkysc <37940565+blinkysc@users.noreply.github.com>
Co-authored-by: skelUA <v.tkachenko.it@gmail.com>
Co-authored-by: vrachv <52053491+vrachv@users.noreply.github.com>
Co-authored-by: vrachv <vrachv@outlook.com>
Co-authored-by: killerwife <killerwife@gmail.com>
Co-authored-by: MantisLord <sabinprosper@gmail.com>
Co-authored-by: Smirnov Sergey <lyns@lyns.pro>
Co-authored-by: p-tkachuk <chatagrag3@gmail.com>
Co-authored-by: Hexadecimal <hd@hd.hd>
Co-authored-by: @cgrahamseven <chrisgraham@protonmail.com>
Co-authored-by: cgrahamseven <chris.graham@protonmail.com>
Co-authored-by: Gabriele Sani <sani.gabriele@protonmail.com>
Co-authored-by: chaosua <544218+chaosua@users.noreply.github.com>
Co-authored-by: murmeli666 <mihail@mihailmihail.fi>
Co-authored-by: 天鹿 <18535853+PkllonG@users.noreply.github.com>
Co-authored-by: Mykhailo Redko <ovitnez@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CORE Related to the core DB related to the SQL database file-cpp Used to trigger the matrix build Ready to be Reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants