Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

patch L-11, L-08 #6

Merged
merged 2 commits into from
Jul 12, 2024
Merged

patch L-11, L-08 #6

merged 2 commits into from
Jul 12, 2024

Conversation

dudong2
Copy link
Collaborator

@dudong2 dudong2 commented Jul 2, 2024

Closes: #XXX

Description

L-11

Incorrect import of protobuf

  • replace "github.com/gogo/protobuf" -> "github.com/cosmos/gogoproto"

L-08

Using deprecated sdk.Msg interface as input

  • unused function StdSignBytes from app/ante/utils_test.go

Closes: L-11, L-08


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@dudong2 dudong2 self-assigned this Jul 2, 2024
@dudong2 dudong2 requested a review from poorphd July 2, 2024 08:07
Copy link
Collaborator

@poorphd poorphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 requested review from dongsam and zsystm July 9, 2024 14:50
Copy link
Collaborator

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit b7a8467 into canto-v8/develop Jul 12, 2024
19 of 28 checks passed
@dudong2 dudong2 deleted the patch/issue-L-11,L-08 branch July 12, 2024 05:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants