SO-4992: ETag and Cache-Control header support #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides the most accurate ETag value that can be used for any kind of content request, be it versioned or not.
...when we build the response upon receiving a resolved/rejected promise. This prevents header duplication and hopefully overrides anything that Spring incorrectly adds by default.
Add it to AllSnomedApiTests suite.
...header handling
...promise body if the body is a Spring ResponseEntity instance
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 9.x #1270 +/- ##
============================================
+ Coverage 48.19% 48.21% +0.01%
- Complexity 13906 13922 +16
============================================
Files 1944 1946 +2
Lines 95081 95121 +40
Branches 10983 10985 +2
============================================
+ Hits 45822 45859 +37
+ Misses 46270 46267 -3
- Partials 2989 2995 +6 ☔ View full report in Codecov by Sentry. |
nagyo
approved these changes
Apr 2, 2024
| public class RateLimitConfig { | ||
|
|
||
| @Min(0) | ||
| private long overdraft = 0L; |
There was a problem hiding this comment.
I would love to see a simple one-sentence explanation about the purpose of these values. For future devs I think it would be extremely useful.
...which replaces the `api.rate_limit.overdraft` config key Add some documentation references to ease understanding of how rate-limiting in Snow Owl works.
|
👌🏻 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
ETagandCache-Controlheaders so that HTTP clients, proxies, and intermediaries can cache the responses earlier than caching only in an HTTP browser.Still somewhat blocked by spring-projects/spring-security#12865. We need to figure out a way of preventing Spring from adding the default cache-control headers when we set our own.Resolved the above in the meantime by explicitly setting the headers in the response before Spring can write its defaults incorrectly.
Background: https://snowowl.atlassian.net/browse/SO-4992