Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(snomed): support expanding type() and destination() concepts on OWL Refset members #1301

Merged

Conversation

cmark
Copy link
Member

@cmark cmark commented Jun 20, 2024

No description provided.

...concepts on owl reference set members
@cmark cmark added the feature label Jun 20, 2024
@cmark cmark requested review from apeteri and nagyo June 20, 2024 08:40
@cmark cmark self-assigned this Jun 20, 2024
@cmark cmark marked this pull request as ready for review June 20, 2024 09:04
Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍃

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 43.43434% with 56 lines in your changes missing coverage. Please review.

Project coverage is 48.45%. Comparing base (d5b74a0) to head (4e4ecf7).

Files Patch % Lines
...e/converter/SnomedReferenceSetMemberConverter.java 34.88% 25 Missing and 3 partials ⚠️
...omed/core/domain/refset/SnomedOWLRelationship.java 58.69% 14 Missing and 5 partials ⚠️
...ore/index/entry/SnomedOWLRelationshipDocument.java 0.00% 6 Missing ⚠️
...tore/index/entry/SnomedRefSetMemberIndexEntry.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                9.x    #1301      +/-   ##
============================================
- Coverage     48.46%   48.45%   -0.01%     
- Complexity    13999    14019      +20     
============================================
  Files          1947     1948       +1     
  Lines         95202    95293      +91     
  Branches      11003    11011       +8     
============================================
+ Hits          46135    46175      +40     
- Misses        46043    46085      +42     
- Partials       3024     3033       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmark cmark merged commit b45cdde into 9.x Jun 20, 2024
4 of 5 checks passed
@cmark cmark deleted the feature/SO-6169-support-type-destination-expand-owl-members branch June 20, 2024 13:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants