Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SO-6223: Remove log4j 1.x jars completely #1315

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

adamfilep
Copy link
Contributor

No description provided.

@adamfilep adamfilep requested review from cmark and apeteri August 15, 2024 08:06
@adamfilep adamfilep self-assigned this Aug 15, 2024
Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmark cmark changed the title SO-6223: Remove log4j jars from pom.xml SO-6223: Remove log4j jars completely Aug 15, 2024
@cmark cmark changed the title SO-6223: Remove log4j jars completely SO-6223: Remove log4j 1.x jars completely Aug 15, 2024
Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmark cmark merged commit 5ae692b into 9.x Aug 15, 2024
1 of 2 checks passed
@cmark cmark deleted the issue/SO-6223-replace-log4j-with-reload4j branch August 15, 2024 14:52
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.46%. Comparing base (9de4670) to head (d935bca).
Report is 6 commits behind head on 9.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                9.x    #1315      +/-   ##
============================================
- Coverage     48.46%   48.46%   -0.01%     
+ Complexity    14035    14033       -2     
============================================
  Files          1949     1949              
  Lines         95377    95377              
  Branches      11024    11024              
============================================
- Hits          46226    46225       -1     
+ Misses        46110    46109       -1     
- Partials       3041     3043       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants