Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

SO-6276: Improve detection of non-connected cycles in SimpleTaxonomyGraph #1322

Merged
merged 2 commits into from
Sep 18, 2024
Merged

SO-6276: Improve detection of non-connected cycles in SimpleTaxonomyGraph #1322

merged 2 commits into from
Sep 18, 2024

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented Sep 17, 2024

No description provided.

@apeteri
fix(core): Add cycle detection that does not depend on indirect...
6d7b168 
...ancestor and descendant computations (these might miss concepts that
become a separate tree by forming a cycle).
@apeteri
fix(core.taxonomy): Throw CycleDetectedException in the simple...
070ba9a 
...taxonomy change processor implementation if information about the
presence of cycle is received, BadRequestException if the tree could not
be updated otherwise
@apeteri apeteri requested review from cmark and nagyo September 17, 2024 16:38
@apeteri apeteri self-assigned this Sep 17, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.73171% with 12 lines in your changes missing coverage. Please review.

Project coverage is 48.57%. Comparing base (4118d43) to head (070ba9a).
Report is 3 commits behind head on 9.x.

Files with missing lines Patch % Lines
...l/core/taxonomy/SimpleTaxonomyChangeProcessor.java 0.00% 8 Missing ⚠️
...nal/snowowl/core/taxonomy/SimpleTaxonomyGraph.java 87.87% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##                9.x    #1322   +/-   ##
=========================================
  Coverage     48.57%   48.57%           
  Complexity    14070    14070           
=========================================
  Files          1949     1949           
  Lines         95382    95406   +24     
  Branches      11025    11026    +1     
=========================================
+ Hits          46329    46343   +14     
- Misses        46020    46029    +9     
- Partials       3033     3034    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nagyo
nagyo approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cmark
cmark approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

@cmark cmark merged commit 9240139 into 9.x Sep 18, 2024
5 checks passed
@cmark cmark deleted the issue/SO-6276-lcs-parent-update-cycles branch September 18, 2024 07:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cmark cmark cmark approved these changes

@nagyo nagyo nagyo approved these changes

Assignees

@apeteri apeteri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apeteri @cmark @nagyo