Allow evaluation of "top of set" and "bottom of set" ECL expressions #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- "top of set" expressions - "bottom of set" expressions - alternate identifiers (recognized but currently unsupported)
...to match signature change in parent class
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 9.x #1331 +/- ##
============================================
+ Coverage 48.57% 48.59% +0.01%
- Complexity 14073 14084 +11
============================================
Files 1950 1950
Lines 95449 95467 +18
Branches 11028 11021 -7
============================================
+ Hits 46363 46388 +25
Misses 46049 46049
+ Partials 3037 3030 -7 ☔ View full report in Codecov by Sentry. |
cmark
approved these changes
Oct 3, 2024
nagyo
reviewed
Oct 3, 2024
|
|
||
| private Set<String> toStringSet(final long[] idArray) { | ||
| if (idArray == null || idArray.length < 1) { | ||
| return newHashSet(); |
There was a problem hiding this comment.
I'm just wondering if this should be mutable. Or would it be possible to use an immutable empty set here?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.