Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SO-4882: Upgrade empty extension bug #849

Merged
merged 7 commits into from
Jul 14, 2021

Conversation

molnarlaura
Copy link
Contributor

No description provided.

@molnarlaura molnarlaura requested a review from cmark July 13, 2021 14:07
@molnarlaura molnarlaura self-assigned this Jul 13, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2021

Codecov Report

Merging #849 (a48ea74) into 7.x (f097b89) will increase coverage by 0.01%.
The diff coverage is 92.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                7.x     #849      +/-   ##
============================================
+ Coverage     62.30%   62.32%   +0.01%     
- Complexity    11339    11345       +6     
============================================
  Files          1610     1610              
  Lines         54819    54834      +15     
  Branches       5434     5437       +3     
============================================
+ Hits          34155    34173      +18     
+ Misses        18461    18455       -6     
- Partials       2203     2206       +3     
Impacted Files Coverage Δ
...ystem/CodeSystemUpgradeSynchronizationRequest.java 93.54% <ø> (+11.73%) ⬆️
...national/index/revision/BaseRevisionBranching.java 90.64% <92.00%> (+4.27%) ⬆️
...x/src/com/b2international/index/util/JsonDiff.java 75.29% <0.00%> (-2.36%) ⬇️
...onal/snowowl/snomed/core/tree/TerminologyTree.java 80.76% <0.00%> (-1.93%) ⬇️
.../b2international/index/es/client/EsClientBase.java 65.47% <0.00%> (-1.20%) ⬇️
...src/com/b2international/index/revision/Commit.java 60.95% <0.00%> (-0.69%) ⬇️
.../snomed/core/ecl/SnomedEclRefinementEvaluator.java 89.01% <0.00%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f097b89...a48ea74. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jul 13, 2021

This pull request introduces 1 alert when merging d3309fd into f097b89 - view on LGTM.com

new alerts:

  • 1 for Spurious Javadoc @param tags

@molnarlaura molnarlaura requested a review from cmark July 14, 2021 07:39
@cmark cmark added the bug label Jul 14, 2021
Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmark cmark merged commit 33750fe into 7.x Jul 14, 2021
@cmark cmark deleted the issue/SO-4882-upgrade-empty-extension-bug branch July 14, 2021 08:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants