Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SO- 4890: support includeNull and pretty query parameters #857

Merged

Conversation

cmark
Copy link
Member

@cmark cmark commented Jul 19, 2021

Both query parameters work with empty or true values. Any other value considered false and will not enable the feature.

  • includeNull - includes all properties of the response model to be
    serialized to the JSON representation even if the value is null. The
    default behavior is to omit null values.
  • pretty - pretty print the output to make it human-readable

Fixes #486.

...to configure returned JSON representation

Both query parameter work with empty or `true` values. Any other value
considered `false` and will not enable the feature.
* `includeNull` - includes all properties of the response model to be
serialized to the JSON representation even if the value is `null`. The
default behavior is to omit `null` values.
* `pretty` - pretty print the output to make it human-readable
@cmark cmark added the feature label Jul 19, 2021
@cmark cmark requested a review from apeteri July 19, 2021 13:54
@cmark cmark self-assigned this Jul 19, 2021
@cmark cmark linked an issue Jul 19, 2021 that may be closed by this pull request
...object mappers until not requested and to allow future extensions of
serialization feature configurations.
@codecov-commenter
Copy link

Codecov Report

Merging #857 (c79a500) into 8.x (b90b120) will decrease coverage by 0.00%.
The diff coverage is 56.66%.

❗ Current head c79a500 differs from pull request most recent head b69b88a. Consider uploading reports for the commit b69b88a to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##                8.x     #857      +/-   ##
============================================
- Coverage     60.57%   60.57%   -0.01%     
- Complexity    11075    11080       +5     
============================================
  Files          1651     1651              
  Lines         54258    54284      +26     
  Branches       5263     5269       +6     
============================================
+ Hits          32869    32884      +15     
- Misses        19265    19270       +5     
- Partials       2124     2130       +6     
Impacted Files Coverage Δ
...ernational/snowowl/core/rest/SnowOwlApiConfig.java 88.23% <56.66%> (-10.69%) ⬇️
...national/snowowl/core/locks/OperationLockInfo.java 43.33% <0.00%> (-3.34%) ⬇️
.../snomed/core/ecl/SnomedEclRefinementEvaluator.java 86.17% <0.00%> (+0.26%) ⬆️
...index/src/com/b2international/index/es/EsNode.java 85.88% <0.00%> (+1.17%) ⬆️
...onal/snowowl/snomed/core/tree/TerminologyTree.java 87.75% <0.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b90b120...b69b88a. Read the comment docs.

@cmark cmark merged commit 942cf75 into 8.x Jul 19, 2021
@cmark cmark deleted the improvement/SO-4890-support-includeNull-pretty-query-parameters branch July 19, 2021 14:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pretty print option on REST API endpoints
3 participants