Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: automatically configure known language dialect aliases after... #876

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

cmark
Copy link
Member

@cmark cmark commented Aug 12, 2021

...successful RF2 import

Existing dialect configuration is not updated and kept as is so client
can act if they need to include additional refset IDs after an RF2
import.

...successful RF2 import

Existing dialect configuration is not updated and kept as is so client
can act if they need to include additional refset IDs after an RF2
import.
@cmark cmark added the feature label Aug 12, 2021
@cmark cmark requested a review from apeteri August 12, 2021 08:40
@cmark cmark self-assigned this Aug 12, 2021
Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.execute(context);

/*
* XXX: The default language in locales is always "en", as there is no
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could get the language code part from the dataset by looking at the language code of each description that is a member of the reference set in question. Something for the future.

@cmark cmark merged commit 9fecf0c into 8.x Aug 12, 2021
@cmark cmark deleted the feature/automatically-configure-dialect-aliases branch August 12, 2021 09:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants