Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SNRAY-124: Search concepts by membership #879

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented Aug 17, 2021

This PR adds a new concept search property named isActiveMemberOf; matching concepts should have at least one active member referring to them in any of the listed reference sets.

The previous type of this variable was short; it was changed to String,
which has to be compared by content.
@apeteri apeteri self-assigned this Aug 17, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #879 (780e183) into 8.x (5900031) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                8.x     #879      +/-   ##
============================================
+ Coverage     62.46%   62.58%   +0.11%     
- Complexity    11465    11506      +41     
============================================
  Files          1709     1711       +2     
  Lines         55001    55054      +53     
  Branches       5267     5270       +3     
============================================
+ Hits          34359    34456      +97     
+ Misses        18467    18425      -42     
+ Partials       2175     2173       -2     
Impacted Files Coverage Δ
...owl/snomed/core/rest/SnomedConceptRestService.java 97.46% <100.00%> (+0.03%) ⬆️
...omed/core/rest/domain/SnomedConceptRestSearch.java 52.63% <100.00%> (+4.06%) ⬆️
...e/index/change/ReferringMemberChangeProcessor.java 100.00% <100.00%> (ø)
...nternational/snowowl/core/events/util/Promise.java 69.64% <0.00%> (-1.79%) ⬇️
...datastore/index/change/ConceptChangeProcessor.java 95.89% <0.00%> (-0.92%) ⬇️
...om/b2international/index/revision/StagingArea.java 93.79% <0.00%> (-0.34%) ⬇️
...owowl/core/rest/suggest/SuggestRestParameters.java 100.00% <0.00%> (ø)
.../snowowl/core/rest/suggest/SuggestRestService.java 100.00% <0.00%> (ø)
...national/index/revision/BaseRevisionBranching.java 86.36% <0.00%> (+1.29%) ⬆️
...2international/commons/options/HashMapOptions.java 50.00% <0.00%> (+1.35%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5900031...780e183. Read the comment docs.

Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmark cmark merged commit e9d1504 into 8.x Aug 17, 2021
@cmark cmark deleted the feature/SNRAY-124_search_concepts_by_membership branch August 17, 2021 15:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants