Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MRCM export improvements #910

Merged
merged 2 commits into from
Oct 1, 2021
Merged

MRCM export improvements #910

merged 2 commits into from
Oct 1, 2021

Conversation

nagyo
Copy link
Member

@nagyo nagyo commented Sep 30, 2021

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #910 (0ee21db) into 7.x (a2ff0bd) will increase coverage by 0.00%.
The diff coverage is 65.62%.

Impacted file tree graph

@@            Coverage Diff            @@
##                7.x     #910   +/-   ##
=========================================
  Coverage     62.31%   62.31%           
- Complexity    11384    11385    +1     
=========================================
  Files          1611     1611           
  Lines         55064    55088   +24     
  Branches       5466     5466           
=========================================
+ Hits          34314    34329   +15     
- Misses        18528    18538   +10     
+ Partials       2222     2221    -1     
Impacted Files Coverage Δ
.../snowowl/snomed/core/mrcm/io/JsonMrcmExporter.java 0.00% <0.00%> (ø)
...l/snowowl/snomed/core/mrcm/io/CsvMrcmExporter.java 100.00% <100.00%> (ø)
...onal/snowowl/snomed/core/tree/TerminologyTree.java 80.76% <0.00%> (-1.93%) ⬇️
.../snomed/core/ecl/SnomedEclRefinementEvaluator.java 88.79% <0.00%> (-0.22%) ⬇️
...wl/fhir/core/model/conceptmap/TranslateResult.java 83.87% <0.00%> (+6.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2ff0bd...0ee21db. Read the comment docs.

@nagyo nagyo requested a review from cmark October 1, 2021 08:16
Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmark cmark merged commit a77ce48 into 7.x Oct 1, 2021
@cmark cmark deleted the issue/mrcm_export_improvements branch October 1, 2021 08:21
@apeteri apeteri added the port-to-8.x Pull requests that need a complementary PR targeting the 8.x stream label Apr 11, 2023
@apeteri
Copy link
Member

apeteri commented Apr 11, 2023

Not applicable to 8.x as MRCM content will be maintained in the form of reference set members.

@apeteri apeteri removed the port-to-8.x Pull requests that need a complementary PR targeting the 8.x stream label Apr 11, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants