feat(snomed): introduce NamespaceIdProvider to extract namespace values. #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...from a collection of namespaceConceptIds Introduce namespaceConceptId in SNOMED CT component create endpoints to support creation of SNOMED CT content by specifying the namespaceConceptId as opposed to the actual namespace value. The system will be able to extract this information from the namespace concept and use it to generate the new IDs with the correct namespace.
apeteri
reviewed
Oct 13, 2021
...datastore/src/com/b2international/snowowl/snomed/core/domain/NamespaceConceptIdStrategy.java
Show resolved
Hide resolved
apeteri
reviewed
Oct 13, 2021
....datastore/src/com/b2international/snowowl/snomed/datastore/request/NamespaceIdProvider.java
Show resolved
Hide resolved
feature/support-namespace-concept-ids-in-create-api Conflicts: snomed/com.b2international.snowowl.snomed.datastore/src/com/b2international/snowowl/snomed/core/SnomedPlugin.java
...id generation strategy, so it can be reused easily.
...fields when fetching namespace concept FSNs
Codecov Report
@@ Coverage Diff @@
## 8.x #920 +/- ##
============================================
+ Coverage 62.73% 63.28% +0.55%
+ Complexity 11684 11459 -225
============================================
Files 1727 1675 -52
Lines 55831 54314 -1517
Branches 5305 5077 -228
============================================
- Hits 35023 34373 -650
+ Misses 18586 17780 -806
+ Partials 2222 2161 -61
Continue to review full report at Codecov.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...from a collection of namespaceConceptIds
Introduce namespaceConceptId in SNOMED CT component create endpoints to
support creation of SNOMED CT content by specifying the
namespaceConceptId as opposed to the actual namespace value. The system
will be able to extract this information from the namespace concept and
use it to generate the new IDs with the correct namespace.