Support index-level request caching #931
Conversation
Cache underlying index requests if they are executed on released content.
...so they can be cached properly
...filter with single valued arrays
| * @return whether the search should cache the resulting hits in the underlying index system or not | ||
| */ | ||
| protected boolean cacheHits(C context) { | ||
| return Revision.class.isAssignableFrom(getFrom()) && context.optionalService(PathWithVersion.class).isPresent(); |
There was a problem hiding this comment.
PathWithVersion does not always contain a version URI; when the original request path does not correspond to a version identifier, eg. when it contains a branch separator character, only an absolute branch path will be returned from the resolver:
There was a problem hiding this comment.
I agree, it would be nice to introduce a more rigorous condition for this, given that it is quite hard to validate if a search result is indeed correct when it was cached.
There was a problem hiding this comment.
I'm open to any suggestions. This was the easiest way at the moment to determine whether a request is being executed on a version or not (and I think it's not that bad 😅).
There was a problem hiding this comment.
@apeteri see this piece of code, the PathWithVersion instance gets injected only when it has a version URI:
https://github.com/b2ihealthcare/snow-owl/pull/931/files#diff-a4877e9655543b6f3a4aeb80fb2df33cfb521470f823c273b36214aad0b087ecR47
| * @return whether the search should cache the resulting hits in the underlying index system or not | ||
| */ | ||
| protected boolean cacheHits(C context) { | ||
| return Revision.class.isAssignableFrom(getFrom()) && context.optionalService(PathWithVersion.class).isPresent(); |
There was a problem hiding this comment.
I agree, it would be nice to introduce a more rigorous condition for this, given that it is quite hard to validate if a search result is indeed correct when it was cached.
This PR introduces index-level search request caching and potential configuration on request API level via cacheHits(ServiceProvider).
By default the system will cache: