SO-4080: optimize bool index queries #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. merge term filters specified on the same field to reduce the number of bool query clauses 2. flatten deep bool query hierarchies to reduce the chance of getting HTTP 400 error due to `indices.query.bool.max_nested_depth` setting, which defaults to depth of `20`.
...an HTTP 400 error
apeteri
requested changes
Feb 11, 2022
commons/com.b2international.index/src/com/b2international/index/es/EsDocumentSearcher.java
Show resolved
Hide resolved
...com.b2international.index/src/com/b2international/index/query/AbstractExpressionBuilder.java
Show resolved
Hide resolved
...com.b2international.index/src/com/b2international/index/query/AbstractExpressionBuilder.java
Outdated
Show resolved
Hide resolved
...com.b2international.index/src/com/b2international/index/query/AbstractExpressionBuilder.java
Show resolved
Hide resolved
...instead of always using must (which is mainly for scoring)
They cause the resulting boolean logic to change from and to or, which leads to incorrect results.
...by using the intersection of the specified values
Codecov Report
@@ Coverage Diff @@
## 8.x #976 +/- ##
============================================
+ Coverage 64.57% 64.60% +0.02%
- Complexity 11824 11876 +52
============================================
Files 1689 1689
Lines 55470 55548 +78
Branches 5120 5152 +32
============================================
+ Hits 35821 35887 +66
- Misses 17460 17467 +7
- Partials 2189 2194 +5
Continue to review full report at Codecov.
|
...Sets.intersection when collapsing term filters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes bool index queries to reduce (and hopefully eliminate) the chance of hitting search errors:
indices.query.bool.max_nested_depthsetting, which defaults to depth of20.