Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add generic taxonomy change processor #981

Merged
merged 13 commits into from
Mar 9, 2022
Merged

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented Feb 21, 2022

The PR also removes LongBidiMapWithInternalId, which previously provided an SCTID 🡘 long storage key mapping in addition to an integer index. Since it was only used for an SCTID 🡘 integer index mapping, it is replaced with a LongOrderedSet implementation.

@apeteri apeteri self-assigned this Feb 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2022

Codecov Report

Merging #981 (f21f7e3) into 8.x (fd56483) will increase coverage by 0.16%.
The diff coverage is 50.87%.

Impacted file tree graph

@@             Coverage Diff              @@
##                8.x     #981      +/-   ##
============================================
+ Coverage     64.60%   64.76%   +0.16%     
- Complexity    11878    12099     +221     
============================================
  Files          1689     1697       +8     
  Lines         55551    56273     +722     
  Branches       5152     5236      +84     
============================================
+ Hits          35887    36445     +558     
- Misses        17469    17599     +130     
- Partials       2195     2229      +34     
Impacted Files Coverage Δ
...com/b2international/collections/PrimitiveMaps.java 38.09% <0.00%> (+2.19%) ⬆️
...ional/collections/FastUtilPrimitiveMapFactory.java 40.74% <0.00%> (+6.12%) ⬆️
...l/core/taxonomy/SimpleTaxonomyChangeProcessor.java 0.00% <0.00%> (ø)
...nternational/snowowl/core/taxonomy/SimpleEdge.java 31.57% <31.57%> (ø)
...ational/commons/collections/SparseFixedBitSet.java 32.74% <32.74%> (ø)
.../src/com/b2international/commons/CompareUtils.java 53.12% <50.00%> (+3.12%) ⬆️
...nal/snowowl/core/taxonomy/SimpleTaxonomyGraph.java 76.92% <76.92%> (ø)
...ernational/commons/collect/LongOrderedSetImpl.java 85.93% <85.93%> (ø)
...ernational/commons/collections/OrderedSetImpl.java 86.36% <86.36%> (ø)
...owowl/snomed/datastore/taxonomy/TaxonomyGraph.java 73.78% <87.50%> (+0.16%) ⬆️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd56483...f21f7e3. Read the comment docs.

...starting index is equal or greater than the bit set's length.
@cmark cmark self-requested a review March 7, 2022 16:59
Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really impressive @apeteri! I'm going to digest the SimpleTaxonomyGraph and ChangeProcessor classes tomorrow.

Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmark cmark merged commit 0fae059 into 8.x Mar 9, 2022
@cmark cmark deleted the feature/taxonomy_change_processor branch March 9, 2022 09:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants