-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add generic taxonomy change processor #981
Conversation
...insertion-ordered sets (both Object and primitive long version is supported).
Codecov Report
@@ Coverage Diff @@
## 8.x #981 +/- ##
============================================
+ Coverage 64.60% 64.76% +0.16%
- Complexity 11878 12099 +221
============================================
Files 1689 1697 +8
Lines 55551 56273 +722
Branches 5152 5236 +84
============================================
+ Hits 35887 36445 +558
- Misses 17469 17599 +130
- Partials 2195 2229 +34
Continue to review full report at Codecov.
|
...starting index is equal or greater than the bit set's length.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really impressive @apeteri! I'm going to digest the SimpleTaxonomyGraph and ChangeProcessor classes tomorrow.
commons/com.b2international.commons/src/com/b2international/commons/collect/LongOrderedSet.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The PR also removes
LongBidiMapWithInternalId
, which previously provided an SCTID 🡘 long storage key mapping in addition to an integer index. Since it was only used for an SCTID 🡘 integer index mapping, it is replaced with aLongOrderedSet
implementation.