NNormalize referring to environment variables for max compatibility. #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rpavlik
commented
Apr 7, 2023
•
rpavlik
commented
- Remove curly brackets for better copy/paste compat with fish
- Add $ to mentions of variables in paths that do not already have them
- Remove curly brackets for compat with fish - Add $ to mentions of variables in paths that do not already ahve them
|
Thank you very much for this! May I ask how you did this? If you wrote a script or something, maybe we could convert that to a GitHub action to test if new PRs comply with this automatically? |
b3nj5m1n
changed the title
|
Just a bunch of search and replace in tree. We could probably do a sed script though. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.