make active tab in fullscreen more obvious #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When the Job exit callback is invoked, the job may be freed too
soon. (Yasuhiro Matsumoto)
Solution: Increase refcount.
Problem: Win16 docs still referenced. Solution: Remove Win16 files from the docs Makefile. (Kenichi Ito)
Problem: Compiler warning. (Cesar Romani) Solution: Initialize variable.
Problem: Incomplete function declaration. Solution: Add "void". (Yasuhiro Matsumoto)
Problem: When building with GTK and glib-compile-resources cannot be found
building Vim fails. (Michael Gehring)
Solution: Make GLIB_COMPILE_RESOURCES empty instead of leaving it at "no".
(nuko8, closes #655)
Problem: Warning for uninitialzed variable. Solution: Set it to zero. (Christian Brabandt)
Problem: Some tests fail for Win32 console version.
Solution: Move the tests to SCRIPTS_MORE2. Pass VIMRUNTIME. (Christian
Brabandt)
Problem: Starting a job hangs in the GUI. (Takuya Fujiwara)
Solution: Don't check if ch_job is NULL when checking for an error.
(Yasuhiro Matsumoto)
Problem: Can't sort inside a sort function. Solution: Use a struct to store the sort parameters. (Jacob Niehus)
Problem: Using DETACH in quotes is not compatible with the Netbeans
interface. (Xavier de Gaye)
Solution: Remove the quotes, only use them for JSON and JS mode.
Problem: Compiler warnings for conversions. Solution: Add type cast.
Problem: Sort test fails on MS-Windows. Solution: Correct the compare function.
Problem: The close-cb option is not implemented yet. Solution: Implemente close-cb. (Yasuhiro Matsumoto)
Problem: The MS-DOS code does not build. Solution: Remove the old MS-DOS code.
Problem: Perl eval doesn't work properly on 64-bit big-endian machine. Solution: Use 32 bit type for the key. (Danek Duvall)
Problem: Having 'autochdir' set during startup and using diff mode doesn't
work. (Axel Bender)
Solution: Don't use 'autochdir' while still starting up. (Christian
Brabandt)
Problem: GTK 3 is not supported. Solution: Add GTK 3 support. (Kazunobu Kuriyama)
Problem: Can't build without the quickfix feature.
Solution: Add #ifdefs. Call ex_ni() for unimplemented commands. (Yegappan
Lakshmanan)
Problem: ch_read() doesn't time out on MS-Windows. Solution: Instead of WM_NETBEANS use select(). (Yukihiro Nakadaira)
Problem: Completion menu flickers.
Solution: Delay showing the popup menu. (Shougo, Justin M. Keyes, closes
#656)
Problem: Leaking memory in cs_print_tags_priv(). Solution: Free tbuf. (idea by Forrest Fleming)
Problem: json_encode() does not handle NaN and inf properly. (David
Barnett)
Solution: For JSON turn them into "null". For JS use "NaN" and "Infinity".
Add isnan().
Problem: MS-Windows doesn't have isnan() and isinf(). Solution: Use _isnan() and _isinf().
Problem: Configure includes GUI despite --disable-gui flag. Solution: Add SKIP_GTK3. (Kazunobu Kuriyama)
Problem: Leaking memory in cscope interface. Solution: Free memory when no tab is found. (Christian Brabandt)
Problem: Compiler warning for indent. (Ajit Thakkar) Solution: Indent normally.
Problem: Compiler warning for indent. (Dominique Pelle) Solution: Fix the indent.
Problem: Using CTRL-] in help on option in parentheses doesn't work.
Solution: Skip the "(" in "('". (Hirohito Higashi)
Problem: Using old style tests for quickfix. Solution: Change them to new style tests. (Yegappan Lakshmanan)
Problem: There is no way to avoid the message when editing a file. Solution: Add the "F" flag to 'shortmess'. (Shougo, closes #686)
Problem: No test for ":help". Solution: Add a test for what 7.4.1568 fixed. (Higashi Higashi)
Problem: Setting 'compatible' in test influences following tests. Solution: Turn 'compatible' off again.
Problem: Tests get stuck at the more prompt. Solution: Move the backspace test out of test_alot.
Problem: ":undo 0" does not work. (Florent Fayolle) Solution: Make it undo all the way. (closes #688)
Problem: Using wrong size for struct. Solution: Use the size for wide API. (Ken Takata)
Problem: Write error of viminfo file is not handled properly. (Christian
Neukirchen)
Solution: Check the return value of fclose(). (closes #682)
Problem: Cannot pass "dict.Myfunc" around as a partial. Solution: Create a partial when expected.
Problem: There is no way to invoke a function later or periodically. Solution: Add timer support.
Problem: Missing changes in channel.c Solution: Include the changes.
Problem: Crash when using function reference. (Luchr) Solution: Set initial refcount. (Ken Takata, closes #690)
Problem: Using ":call dict.func()" where the function is a partial does
not work. Using "dict.func()" where the function does not take a
Dictionary does not work.
Solution: Handle partial properly in ":call". (Yasuhiro Matsumoto)
Problem: Get E923 when using function(dict.func, [], dict). (Kent Sibilev)
Storing a function with a dict in a variable drops the dict if the
function is script-local.
Solution: Translate the function name. Use dict arg if present.
Problem: Warning for unitinialized variable. Solution: Initialize it. (Dominique)
Problem: Timers don't work for Win32 console. Solution: Add check_due_timer() in WaitForChar().
Problem: Partial is not recognized everywhere.
Solution: Check for partial in trans_function_name(). (Yasuhiro Matsumoto)
Add a test.
Problem: Nesting partials doesn't work. Solution: Append arguments. (Ken Takata)
Problem: Compiler warnings with 64 bit compiler. Solution: Add type casts. (Mike Williams)
Problem: Old style test for quickfix. Solution: Turn test 96 into a new style test.
Problem: Combining dict and args with partial doesn't always work. Solution: Use the arguments from the partial.
Problem: Warning for shadowed variable. (Christian Brabandt) Solution: Move the variable into a local block.
Problem: The quickfix title is truncated. Solution: Save the command before it is truncated. (Anton Lindqvist)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been complaints about the tab style in full-screen mode for a long time:
Why-do-fullscreen-tabs-look-different
how-can-i-make-the-active-macvim-tab-more-obvious-in-fullscreen-mode
It is easier for eyes to use the "Metal" style consistently in both normal mode and fullscreen mode. See the following screenshots for comparison:
I've been using this simple fix for a couple of years and I think it might be better to send a PR for this. Do you agree with me?