This repository has been archived by the owner on May 11, 2018. It is now read-only.
Backport: use preset-env and remove flow-strip-types #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
======================================
Coverage 93.2% 93.2%
======================================
Files 4 4
Lines 206 206
Branches 60 60
======================================
Hits 192 192
Misses 9 9
Partials 5 5Continue to review full report at Codecov.
|
|
Is this necessary to backport though? |
|
@hzoo For now it's still the main branch and few people asked me why we are using es2015 instead of env 😕 |
tleunen
reviewed
May 19, 2017
package.json
Outdated
| "loose": true | ||
| } | ||
| ] | ||
| ["env"] |
There was a problem hiding this comment.
Isn't it better to use the current code instead of always the previous version?
So replacing ["env"] with "./src"?
There was a problem hiding this comment.
If you have a bug then it won't build itself
|
@yavorsky lol really.. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing special, just use
preset-envfor backport and removeflow-strip-typesplugin.