This repository has been archived by the owner on May 11, 2018. It is now read-only.
Add stage-3 plugin option #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think |
existentialism
force-pushed
the
stage3
branch
from
f44d5a6 to
fefd2b1
Compare
existentialism
force-pushed
the
stage3
branch
from
fefd2b1 to
3d54191
Compare
existentialism
commented
Sep 19, 2017
| @@ -238,5 +237,14 @@ | |||
| "ios": "10", | |||
| "opera": "45", | |||
| "electron": "1.7" | |||
| } | |||
| }, | |||
| "transform-async-generator-functions": {}, | |||
There was a problem hiding this comment.
This, optional catch binding, and Promise.finally will get filled out once we land #402
existentialism
commented
Sep 19, 2017
|
|
||
| if (!plugin) { | ||
| throw new Error( | ||
| `Could not find plugin "${pluginName}". Ensure there is an entry in ./available-plugins.js for it.`, |
There was a problem hiding this comment.
This kept tripping me up 😜
yavorsky
approved these changes
Sep 19, 2017
hzoo
approved these changes
Sep 19, 2017
|
I'll create a followup to update README, but we should def discuss if there's a better name for the option too. |
Closed
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for enabling transformation of shipping stage 3 features.
EDIT Updating this to: