Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

babili overminifies statements with || '' #176

Closed
muntact opened this issue Oct 5, 2016 · 2 comments · Fixed by #179
Closed

babili overminifies statements with || '' #176

muntact opened this issue Oct 5, 2016 · 2 comments · Fixed by #179

Comments

@muntact
Copy link

muntact commented Oct 5, 2016

With version 0.0.4 of babel-preset-babili, Safe setting a variable to a null string is removed by the minification process.

The following code:

this.value = a || '';

is minified to:

this.value = a;
@loganfsmyth
Copy link
Member

Looks like a dup of #174 ?

@boopathi
Copy link
Member

boopathi commented Oct 5, 2016

Yes. let's track it in #174

@boopathi boopathi closed this as completed Oct 5, 2016
boopathi added a commit that referenced this issue Oct 5, 2016
@boopathi
Fix guarded expressions being utilized elsewhere
443d9bf 
+ (Close #171)
+ (close #174)
+ (close #176)
@boopathi boopathi mentioned this issue Oct 5, 2016
Merged
kangax pushed a commit that referenced this issue Oct 5, 2016
@boopathi @kangax
Fix guarded expressions being utilized elsewhere (#179)
11664eb 
+ (Close #171)
+ (close #174)
+ (close #176)
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix guarded expressions babel/minify
3 participants
@loganfsmyth @boopathi @muntact