Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(minify-dead-code): fix #601 #602

Merged
merged 4 commits into from
Jun 27, 2017
Merged

fix(minify-dead-code): fix #601 #602

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
714e72d
fix(minify-dead-code): fix #601
postspectacular Jun 23, 2017
db6a375
fix(minify-dead-code): fix #601 - reverting to previous fix, now pass…
postspectacular Jun 23, 2017
8f39139
format(minify-dead-code): auto-fix formatting
postspectacular Jun 23, 2017
5686ac1
refactor(miniy-dead-code): update array check
postspectacular Jun 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/babel-plugin-minify-dead-code-elimination/src/remove-use-strict.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ function isStrict(block) {
}

function getUseStrictDirectives(block) {
return block.get("directives").filter(directive => {
return directive.node.value.value === useStrict;
});
var dir = block.get("directives");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not check for array? Array.isArray()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

return Array.isArray(dir)
? dir.filter(function(directive) {
return directive.node.value.value === useStrict;
})
: [];
}