fix(mangle) - mark the correct eval scope during mangling #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boopathi
reviewed
Dec 19, 2017
| @@ -480,7 +481,9 @@ module.exports = babel => { | |||
| } else { | |||
| throw new Error( | |||
| `Unexpected Rename Error: ` + | |||
| `Trying to replace "${node.name}": from "${oldName}" to "${newName}". ` + | |||
| `Trying to replace "${ | |||
| node.name | |||
There was a problem hiding this comment.
maybe update prettier that's used in your editor? Also, is yarn fix changing this too ?
There was a problem hiding this comment.
yarn fix doesnt change this but changes some other things.. I have updated the editor prettier.. something weird.
vigneshshanmugam
force-pushed
the
fix-366
branch
from
858ae26
to
b12af86
Compare
|
@boopathi restart appveyor build, some caching issue and add me there. |
boopathi
approved these changes
Dec 19, 2017
I can't find where to add. I'll check it. |
|
Omg appveyor, crazy slow. 7 mins and counting. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were always checking the wrong scope that was marked by DCE in another pass.