This repository was archived by the owner on Nov 4, 2021. It is now read-only.
Silence notice thrown by php74 on array offset access of non-array types #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -348,7 +348,7 @@ public function map(Builder $builder, $results, $model) | |||
| */ | |||
| public function getTotalCount($results) | |||
| { | |||
| return $results['hits']['total']['value']; | |||
| return $results['hits']['total']['value'] ?? 0; | |||
There was a problem hiding this comment.
The change is just one line and doesn't affect the existing functionality. Our team is blocked rn so we'd really appreciate it if we could get this change fixed :)
|
@zehao-sean-huang merged and released in v4.2.3. But I recommend you to migrate to elastic-scout-driver and elastic-scout-driver-plus. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: 🐛 Bug report --
about: PHP 7.4 Array Offset Access Throws out a Notice
Versions
Description
When using laravel tinker, we tried the following command:
Model::search('text')->get(), and it outputs the following error message.Simple Fix
Just a one line change using the following syntax:
$not_array['key'] ?? 0. This silences the error, enabling the code to execute normally and fall back to a normal value if the key is not found.