Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Various fixes to better support doxygen's lexer files #36

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

doxygen
Copy link
Contributor

@doxygen doxygen commented Oct 21, 2024

Thanks for the nice VSCode plugin.

While testing it on Doxygen's lexer files, I ran into a couple of small issues, and decided to dive into the code and try to fix them.

Here is the list of fixes:

  • Prevent <,>,{,} characters inside character ranges from breaking the scanner.
  • Allow TokenType.Action also in WaitingAction state.
  • Allow comments in definition section and condition blocks.
  • Allow comments at more places in the syntax highlighting.
  • Fix compile issue with undefined in changeValue<E>().

- Prevent <,>,{,} characters inside character ranges from breaking the scanner
- Allow TokenType.Action also in WaitingAction state
- Allow comments in definition section and condition blocks
- Allow comments at more places in the syntax highlighting
- Fix compile issue with undefined in changeValue<E>()
@babyraging
Copy link
Owner

Hi there, thank you very much for the PR, sorry for the late response.

Code looks good, I'll merge it and push a new version as soon as I get back home.

@doxygen
Copy link
Contributor Author

doxygen commented Nov 12, 2024

@babyraging Any update on when this will be merged?

@babyraging babyraging merged commit 04de4de into babyraging:master Nov 12, 2024
@babyraging
Copy link
Owner

@doxygen hi there, sorry for the late response....have been busy IRL...

PR merged and new version has been published, you should now be able to update it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants