Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

View method issue #106

Closed
laryn opened this issue Dec 3, 2021 · 2 comments · Fixed by #112
Closed

View method issue #106

laryn opened this issue Dec 3, 2021 · 2 comments · Fixed by #112

Comments

@laryn
Copy link
Member

laryn commented Dec 3, 2021

From @herbdool in another thread:

I noticed

return entity_get_controller($this->entityType())->view(array($this), $view_mode, $langcode, $page);
which is calling a view method but it's not in core yet and it doesn't check that it's using EntityPlusControllerInterface.

Maybe have it like https://github.com/backdrop-contrib/entity_plus/blob/489b908ea54ebefc1ce966971c6af09c5e51a0c6/entity_plus.module#L371.

Not sure what would happen otherwise, if/when we add this to core and if the parameters are different.

@laryn
Copy link
Member Author

laryn commented Dec 5, 2021

@herbdool This should do it, right? #112

@herbdool
Copy link
Contributor

herbdool commented Dec 6, 2021

@laryn I think so.

Then down the line you can decide whether to continue using entity_plus for this or use core.

@laryn laryn closed this as completed in #112 Dec 7, 2021
laryn added a commit that referenced this issue Dec 7, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants