-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Extend EntityPlusController and restore/rewrite template_preprocess_paragraphs_item
#113
Comments
template_paragraphs_item_preprocess
template_preprocess_paragraphs_item
argiepiano
added a commit
to argiepiano/paragraphs
that referenced
this issue
Dec 7, 2021
…paragraphs_item` Fixed backdrop-contrib#113
PR: #114 |
laryn
added a commit
that referenced
this issue
Dec 7, 2021
This was referenced Dec 7, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
In recent a issue (#110) and a recent merged PR (#111) we fixed a rendering problem (#91) by eliminating a faulty #theme_wrappers in
paragraphs.field_formatter.inc
and by usingparagraphs_preprocess_entity_plus
instead oftemplate_preprocess_paragraphs_item
to preprocess variables for the templateparagraphs_item.tpl.php
.However, after further discussion with @laryn we decided to, instead, create a new entity controller for Paragraphs to override
buildContent
in order to override the default theme for Entity Plus entities (entity_plus
) and instead use the themeparagraphs_item
. This will allow us to go back to usetemplate_preprocess_paragraphs_item
to preprocess variables, which makes more sense for other developers who want to extend this preprocessing with their own hook implementations in the future.In addition to creating a new entity controller for Paragraphs, we need to rewrite
template_preprocess_paragraphs_item
to do all the necessary preprocessing that used to be done bytemplate_preprocess_entity_plus
.PR coming
The text was updated successfully, but these errors were encountered: