Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Modal buttons get confusing on nested multivalue paragraphs #153

Closed
laryn opened this issue Jan 29, 2023 · 4 comments · Fixed by #154
Closed

Modal buttons get confusing on nested multivalue paragraphs #153

laryn opened this issue Jan 29, 2023 · 4 comments · Fixed by #154
Labels
bug Something isn't working

Comments

@laryn
Copy link
Member

laryn commented Jan 29, 2023

The individual paragraph item buttons (collapse, unpublish, etc.) all get anchored to the bottom of the modal and get very confusing on a modal edit of a nested multi-value paragraph.

Image
@laryn laryn added the bug Something isn't working label Jan 29, 2023
laryn added a commit to laryn/paragraphs that referenced this issue Jan 31, 2023
@laryn
Issue backdrop-contrib#153: Modal edits and nested paragraph actions,…
b3c6afb 
… WIP.

Fixes backdrop-contrib#153.
@laryn laryn mentioned this issue Jan 31, 2023
Merged
@laryn
Copy link
Member Author

laryn commented Jan 31, 2023 •
edited
Loading

WIP here #154

2023-01-31_00-04

@laryn
Copy link
Member Author

laryn commented Jan 31, 2023

I think the linked PR is ready for review and testing if anyone is interested. Otherwise I'll probably test it on a few small personal sites before merging.

@yorkshire-pudding
Copy link
Contributor

LGTM WFM 👍
@laryn - I can confirm the bug and that the PR fixes this. I may be a new convert to the modal admin side having never tried it before due to the experimental warning.

I've done a quick review of the code and it all makes sense to me.

@laryn
Copy link
Member Author

laryn commented Jan 31, 2023

Thanks @yorkshire-pudding!

(Glad to have you trying out the modals! Issues like this one and #152 are why it's still marked experimental)

laryn added a commit that referenced this issue Jan 31, 2023
@laryn
Issue #153: Fix action buttons on modal edits with nested paragraphs.
4eccf42 
Fixes #153.
By @laryn and @yorkshire-pudding.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #153: Fix modal edits and nested paragraph actions. laryn/paragraphs
2 participants
@laryn @yorkshire-pudding