Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[jenkins] Improvements to backend config #2859

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iamEAP
Copy link
Member

@iamEAP iamEAP commented Feb 10, 2025

Hey, I just made a Pull Request!

  • Removes the call to config.getConfig('jenkins'), which unnecessarily throws if the jenkins key is not set.

  • Adds conditional logic to the config schema to make it clearer at build-time how the keys under jenkins should be provided (rather than having to wait until run-time to find out), e.g.

    yarn backstage-cli config:check @backstage-community/plugin-jenkins-backend --strict
    

    Will now show an error in situations like:

    • Only some of apiKey, username, and baseUrl are provided
    • Any of the above are provided, but an instances array is also provided

Closes #2858

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Tests for new functionality and regression tests for bug fixes
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
@iamEAP iamEAP requested a review from a team as a code owner February 10, 2025 12:52
@iamEAP iamEAP requested a review from nickboldt February 10, 2025 12:52
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-jenkins-backend workspaces/jenkins/plugins/jenkins-backend patch v0.11.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Jenkins: Config Schema doesn't match runtime expectations
1 participant