[jenkins] Improvements to backend config #2859
Open
+66
−51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Removes the call to
config.getConfig('jenkins')
, which unnecessarily throws if thejenkins
key is not set.Adds conditional logic to the config schema to make it clearer at build-time how the keys under
jenkins
should be provided (rather than having to wait until run-time to find out), e.g.Will now show an error in situations like:
apiKey
,username
, andbaseUrl
are providedinstances
array is also providedCloses #2858
✔️ Checklist
Signed-off-by
line in the message. (more info)