-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Allow cross-referencing in nav #94
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi again, I was a bit quick - can you update the changelog and the version in setup.py
?
Not sure why the checks are not running. Let's see what happens when you push new changes.
okay updated |
Seems like a test needs updated. |
@haneul Can you go ahead and update the test? I can go ahead and merge this once that's resolved :) |
Sometimes we want to add a page under different subsites (or main site) in a subsite's nav. While linking with ../ may work, but mkdocs can't properly process as it can't find the page.
It shows error like
WARNING - A relative path to 'test/../cross.md' is included in the 'nav' configuration, which is not found in the documentation files
And the navigation title will be None.
This PR fixes it by having normpath for nav link.