Invalid crashpad handler behavior on x86 devices #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konraddysput
requested review from
vlussenburg,
sarahedkins,
perf2711 and
rqbacktrace
sarahedkins
approved these changes
Jan 18, 2022
rqbacktrace
approved these changes
Jan 18, 2022
vlussenburg
approved these changes
Jan 18, 2022
|
After first round of tests, new issues related to similar behavior was detected. I'm planning more changes. |
konraddysput
added a commit
that referenced
this pull request
Mar 14, 2022
* Native client compilation issues in older .NET platforms (#134) * Android compilation issues * Add missing namespace * Apply default when value is below limit (#133) * Apply default when value is below limit * use defaults and different cast for backtracedatabasesettings * Backtrace-cocoa - purge invalid report on game startup * Improvement/prevent duplicated anrs (#135) * Safe way to serialize Backtrace response * Configurable ANR watchdog timeout * Formatting + logger changes * Code review suggestions * Version update * Update CHANGELOG.md * Update CHANGELOG.md * Avoid using unsupported property in not-native builds (#140) * Avoid using unsupported property in not-native builds * Filter out whole base client * Version update * Invalid background exception behavior (#139) * INvalid background exception behaviour * remove cast * Java background exception better variable names/comments * correcet variable name * Updates CHANGELOG for 3.7.2 * Do not test native client on not supported platforms * Invalid cast (#144) * prevent monitor disposing in the disable method (#143) * Use game object name instead of 'backtrace' * Version update + make sure backtrace-unity don't throw an exception when disk is full * Typo * Changelog * Add attributes to runtime xception * fix unable to delete reports when db path has trailing slash * Update README.md (#152) NDK16b support is now baked into the main. * Invalid crashpad handler behavior on x86 devices (#149) * Fixed crashpad handler for x86 * Different meta guid * Different crashpad path to x86/x64 directories * Disable native client on x86 devices on Windows * Disable on editor mode * Android memory usage improvements (#150) * Small nits that should speedup anr algorithm * Background exception handler * Forward crashes in the background exception handler, capture and store unhandled android Exceptions * ANR watchdog adjustements * Version Update * Apply suggestions from code review Change request changes Co-authored-by: Lysanne Pinto <lysannepinto@gmail.com> * Delay breadcrumbs integration initialization * Version 3.7.4 preview 1 * Unity dynamic attributes (#154) * Unity dynamic attributes * background attribute * Release improvements * Preview version update * Version 3.7.4 Co-authored-by: Vincent Lussenburg <vlussenburg@users.noreply.github.com> Co-authored-by: Lysanne Pinto <lysannepinto@gmail.com> Co-authored-by: Sarah Edkins <sedkins@backtrace.io> Co-authored-by: Sarah Edkins <sarahedkins@users.noreply.github.com> Co-authored-by: jasoncdavis0 <jdavis@backtrace.io>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The crashpad handler path doesn't work correctly for x86 builds. It prevents the game from he startup because of the invalid library image. This diff adds: