-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Youtube] Added channel view count and subscriber count badges #6333
Conversation
|
This reverts commit 9d4c8fc.
I had added another issue's code in this PR by mistake. Reverted it with a revert commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @tarun7singh ! 👍🏻
The timing of this pull request is a bit unfortunate. I've just completed quite a tedious compliance process with the YouTube team (see #6276 for a bit more details). One of their conclusive notes is the following:
Please note that the quota extension has been granted ONLY for the use-case(s) mentioned in your quota extension request application and we may change your quota based on your actual quota usage as well as on your continued compliance with the YouTube API Services Terms of Service at any time.
Obviously I hadn't mentioned the new channel badges as they didn't yet exist at the time, but equally one could argue that it's an extension of the same use case. I suggest we move ahead with this, but one my review comments will be particularly important to address to make sure we don't break compliance.
@PyvesB Completed all the requested changes. |
@tarun7singh thanks for promptly addressing my review comments. Things mostly look good, though I think Note that Let me know what you think and feel free to cherry-pick that commit back onto your PR branch. Otherwise, happy to approve as it is, I don't want to be too picky, so it's your call. 😉 |
@PyvesB Yes your code looks much mor econcise but I was not able to successfully cherry pick this commit. can you please do it or tell me how to do it? |
Try the following:
Alternatively, give me write permissions to your fork so that I can push the commit. |
@PyvesB Added your commit to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks all good to me, let's get this merged! 👍
Added Channel view count and subscriber count badge.
Fixes #6111