Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Stop attempting to override Accept header in [GitHub] API provider #7013

Merged
merged 2 commits into from
Sep 12, 2021

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented Sep 12, 2021

Fixes #6960.

@chris48s, is this the kind of test you had in mind?

@PyvesB PyvesB added bug Bugs in badges and the frontend service-badge New or updated service badge labels Sep 12, 2021
@shields-ci
Copy link

shields-ci commented Sep 12, 2021

Messages
📖 ✨ Thanks for your contribution to Shields, @PyvesB!

Generated by 🚫 dangerJS against 9c34ab5

@PyvesB
Copy link
Member Author

PyvesB commented Sep 12, 2021

The test failure will be fixed by #7012.

Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Tbh, I was thinking this would be more important in the case where we try to fix sending application/vnd.github.v3+json. It matters less if we just drop the Accept header but having a test for this will do us no harm :)

@PyvesB PyvesB merged commit ca63f21 into badges:master Sep 12, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Bugs in badges and the frontend service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Accept header is not set as intended
3 participants