-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix BaseFeature serialisation behaviour regression #167
Comments
LachlanMcKee
added a commit
that referenced
this issue
Aug 10, 2022
2 tasks
After further investigation it turns out that this regression actually fixed an outstanding bug in MVICore. However for now until we update to a later version of Kotlin (due to the approach I will take to approach this fix), I will revert the change. If you use a featureScheduler the behaviour change will be introduced, so it is a 'gotcha' for now. I will raise a new PR in the following days to make this behaviour fix opt-in |
LachlanMcKee
added a commit
that referenced
this issue
Aug 10, 2022
LachlanMcKee
added a commit
that referenced
this issue
Aug 10, 2022
[#167] Reverted BaseFeature PostProcessor recursion behaviour change
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
The BaseFeature has a regression related to ordering when using a PostProcessor.
The behaviour previously (which is potentially a bug) would cause the PostProcessor to change the order of news events.
This change should be reverted (to avoid bugs), but also made configurable if that is the desired behaviour.
The text was updated successfully, but these errors were encountered: