Update kotlin to 1.6.21 #162
Conversation
LachlanMcKee
force-pushed
the
update-kotlin-to-1.6.21
branch
from
0b74a7c to
8dfc178
Compare
| @@ -30,13 +29,13 @@ ext { | |||
| rxAndroidVersion = '2.1.1' | |||
|
|
|||
| // DI | |||
| daggerVersion = '2.29.1' | |||
| daggerVersion = '2.43.2' | |||
There was a problem hiding this comment.
dagger and glide had issues with kapt, so I had to update them
|
|
||
| group='com.github.badoo.mvicore' | ||
|
|
||
| android { | ||
| compileSdkVersion 30 | ||
| compileSdkVersion 31 |
There was a problem hiding this comment.
Updates to dagger caused the compile target to no longer be acceptable
| } | ||
|
|
||
| dependencies { | ||
| implementation("com.android.tools.build:gradle:7.1.3") |
There was a problem hiding this comment.
In a follow up PR I will add versionCatalogs, and this will point to that. At the moment there is no easy way to access these build.gradle that specifies this, as this is an includedBuild
Considering I am planning to move to versionCatalog, hopefully this is temporarily acceptable.
| import org.gradle.api.Plugin | ||
| import org.gradle.api.Project | ||
|
|
||
| internal abstract class MviCorePublishPlugin : Plugin<Project> { |
There was a problem hiding this comment.
This is quite simple for now, but if we decide to publish this on mavenCentral, we can amend this and all the binaries will work as expected.
LachlanMcKee
force-pushed
the
update-kotlin-to-1.6.21
branch
5 times, most recently
from
2353d30 to
e7fd546
Compare
| } | ||
|
|
||
| dependencies { | ||
| implementation("com.android.tools.build:gradle:7.2.2") |
There was a problem hiding this comment.
Will use version catalog in a future PR to avoid this duplication
| developer { | ||
| id.set("badoo") | ||
| name.set("Badoo") | ||
| email.set("mvicore@team.bumble.com") |
There was a problem hiding this comment.
Before releasing a new version I will ensure that this group email exists
LachlanMcKee
force-pushed
the
update-kotlin-to-1.6.21
branch
from
e7fd546 to
d491ef1
Compare
LachlanMcKee
force-pushed
the
update-kotlin-to-1.6.21
branch
from
d491ef1 to
793a168
Compare
|
Probably we do not need Idea Gradle plugin (change for a separate PR). https://docs.gradle.org/current/userguide/idea_plugin.html
|
LachlanMcKee
force-pushed
the
update-kotlin-to-1.6.21
branch
from
793a168 to
43b3941
Compare
LachlanMcKee
force-pushed
the
update-kotlin-to-1.6.21
branch
from
43b3941 to
ce510d9
Compare
Description
Updated to Kotlin 1.6.21
Check list
CHANGELOG.mdif required.