Added tests for binder lifecycle extensions #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LachlanMcKee
force-pushed
the
add-unit-tests-for-binder-lifecycle
branch
from
dd8c560 to
91d88f1
Compare
LachlanMcKee
force-pushed
the
add-unit-tests-for-binder-lifecycle
branch
from
91d88f1 to
a27c254
Compare
LachlanMcKee
commented
Feb 7, 2023
| @@ -1,2 +1,14 @@ | |||
| config: | |||
| warningsAsErrors: true | |||
|
|
|||
| style: | |||
There was a problem hiding this comment.
Copied from Appyx. Some of the test descriptions were too long, but the descriptiveness is required
EnderErol
reviewed
Feb 7, 2023
| ArchTaskExecutor.getInstance().setDelegate(null) | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
What about converting these tests to a parametrised one? I think it would be easier to read and add new cases
There was a problem hiding this comment.
As discussed, I'm happy for you to do this in a follow up PR using junit 5
EnderErol
approved these changes
Feb 7, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added unit tests for binder lifecycle extensions (changelog changes are not needed)
Check list
CHANGELOG.mdif required.