-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add junit5 dependency #180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnderErol
force-pushed
the
add-junit5-dependency
branch
from
February 8, 2023 10:35
b0b4d6d
to
d343475
Compare
EnderErol
commented
Feb 8, 2023
mvicore-android/src/test/java/com/badoo/mvicore/android/lifecycle/LifecycleExtensionsTest.kt
Show resolved
Hide resolved
EnderErol
commented
Feb 8, 2023
mvicore/src/test/java/com/badoo/mvicore/newspublishing/NewsPublishingTest.kt
Show resolved
Hide resolved
LachlanMcKee
reviewed
Feb 8, 2023
mvicore/src/test/java/com/badoo/mvicore/feature/AsyncBaseFeatureTest.kt
Outdated
Show resolved
Hide resolved
mvicore/src/test/java/com/badoo/mvicore/newspublishing/NewsPublishingTest.kt
Outdated
Show resolved
Hide resolved
CherryPerry
reviewed
Feb 8, 2023
EnderErol
requested review from
LachlanMcKee and
CherryPerry
and removed request for
LachlanMcKee and
CherryPerry
February 8, 2023 16:27
mvicore-android/src/test/java/com/badoo/mvicore/android/lifecycle/LifecycleExtensionsTest.kt
Fixed
Show fixed
Hide fixed
EnderErol
force-pushed
the
add-junit5-dependency
branch
from
February 8, 2023 18:06
89cbb8d
to
cf66850
Compare
LachlanMcKee
approved these changes
Feb 8, 2023
EnderErol
force-pushed
the
add-junit5-dependency
branch
from
February 9, 2023 11:24
32494ff
to
277303d
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JUnit updated to version 5 (5.9.2)
...
Check list
CHANGELOG.md
if required.