Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Move Plane class into core/util #151

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Move Plane class into core/util #151

wants to merge 7 commits into from

Conversation

Jannetty
Copy link
Member

@Jannetty Jannetty commented Feb 5, 2025 •
edited
Loading

NOTE: This assumes my Vector class is available/merged. Please look at that pull request before looking at this one.

Estimated time to review: Small

Description of changes:

  • Moved Plane class from potts/env to core/util
  • Change Plane constructor to take Double3D as "point on plane"
  • Changed Plane instantiations to give Double3D as parameter instead of voxel
  • Adjusted test in PottsLocation3D, when voxels are distance 0 from plane of division they are sorted randomly into one of the two daughter locations

@Jannetty Jannetty self-assigned this Feb 5, 2025
@Jannetty Jannetty added priority: medium Non-urgent but important task type: feature Improvement or additions to the code base package: core Related to the core package category: util Related to the util subpackages size: small Estimated size of issue or PR is small labels Feb 5, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Jannetty Jannetty

Labels
category: util Related to the util subpackages package: core Related to the core package priority: medium Non-urgent but important task size: small Estimated size of issue or PR is small type: feature Improvement or additions to the code base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jannetty