-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
allowed nested transforms #2
Conversation
The original code only allowed one transform for each file extension. This change allows multiple, nested transforms for each file extension by keeping a stack instead of just a previous value.
added dummy defs to avoid run-time errors if Module is not present
Can you write a unit test / demo example? |
Yes, but I am not up to speed on the testing conventions so this could take a little time. Also, should I do anything about the missing shim file, or just leave that as is? |
I already fixed the collections/shim - this is known problem with Q.v2, just pull this repo into your fork again to get the change Take a look at the |
Okay, I will pull it again. |
Added a test case for nested hooks. see test/use-case-nested.js
I added a test case for nested hooks and it passes. |
Published as 0.2.0, thanks for the feature! |
Added a stack so transforms can be nested for a given extension.
NOTE: had to comment out require("collections/shim") at line 43 of nested qt/q/q.js module; seems like there might be a file missing there somewhere