fix(amis-ui): dependencies中引入video-react@0.15.0依赖,避免_thirds.scss中引入依赖报错的问题 #11412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
安装依赖时,由于amis依赖video-react@0.15.0但amis-ui并没有依赖该包,由于是固定版本(没有^前缀)video-react被安装到amis/node_modules目录中,而没有被提升到根目录下的node_modules,从而导致构建依赖报错
How
在amis-ui下面也安装video-react@0.15.0,使相同的依赖可以提升到./node_modules下在
PS:
为什么要在_third.scss中使用../../../node_modules相对路径的语法,而不是直接引入npm包的语法呢,是否可以直接修改源代码不要引入node_nodules目录?