-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: 注册异步渲染器时删除占位渲染器,修复设置了显隐条件时无法正确渲染的问题 #11544
fix: 注册异步渲染器时删除占位渲染器,修复设置了显隐条件时无法正确渲染的问题 #11544
Conversation
👍 Thanks for this! Please review the labels and make any necessary changes. |
- 当已存在占位渲染器时,在注册异步渲染器时删除占位渲染器 - 解决了在某些情况下(如设置了 visibleOn/hiddenOn 条件)无法渲染的问题
88b4eec
to
f06c88f
Compare
过年好啊! await waitForElementToBeRemoved(() =>
container.querySelector('.cxd-Spinner')
); 我改了一部分,大部分的测试用例都可以通过这种方式修复,但是还是有少部分的dom跟快照对不起来。 |
想听听维护者的意见,是大面积修改测试用例还是用什么trick欺骗jest?(感觉后者不太好) |
抱歉,前面我弄错了,原始对象这里其实直接删除会更方便点。renderer 上删除了 placeholder component ,需要 renderers 数组里面把那个旧的替换成新的,索性还不如直接操作原始对象执行删除! |
感谢,已经合入 |
优化异步渲染器注册逻辑
What
Why