Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test: add metrics test #517

Merged
merged 10 commits into from
Mar 9, 2025
Merged

test: add metrics test #517

merged 10 commits into from
Mar 9, 2025

Conversation

bakito
Copy link
Owner

@bakito bakito commented Mar 7, 2025 •
edited
Loading

add tests to try reproducing the issue described in #511

@coveralls
Copy link

coveralls commented Mar 7, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13750354188

Details

  • 7 of 12 (58.33%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.0%) to 61.631%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/sync/http.go 0 1 0.0%
pkg/sync/scrape.go 0 4 0.0%
Totals Coverage Status
Change from base Build 13750218985: 3.0%
Covered Lines: 1428
Relevant Lines: 2317
💛 - Coveralls

@bakito bakito marked this pull request as ready for review March 9, 2025 16:37
@bakito bakito merged commit 18350f9 into main Mar 9, 2025
7 checks passed
@bakito bakito deleted the stats branch March 9, 2025 16:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bakito @coveralls